-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Update KernelProgramCache.md with details on in-memory eviction #16129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UR is added in this new changes, but there are still plenty of mentions to PI throughout the document. Can we get them updated? PI does no longer exist.
Also, I like this kind of documents to be self-contained, so I don't like us pointing readers to EnvironmentVariables.md in Cache Configuration section. That's just a matter of style, so I will not block approval based on this, but I would like to have the environment variables listed in this document to make it easier for readers.
@steffenlarsen since you reviewed #16062 too, you might want to take a look at this as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments, mostly editorial and for consistency.
In e24d975, I've removed remaining PI references and added cache-related environment variables in this doc itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit, otherwise LGTM.
Co-authored-by: Marcos Maronas <[email protected]>
@intel/llvm-gatekeepers the PR is ready to be merged. |
This PR updates KernelProgramCache.md by:
Partially fixes: #16017