Reuse kernels launcher from main intel driver for benchmarks #3070
+11
−319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
commented
Dec 26, 2024
| if self._build_with_pytorch_dep is False: | ||
| self._build_with_pytorch_dep = True | ||
| self.libraries += ['torch'] | ||
| return os.environ.get("INJECT_PYTORCH", "False") == "True" |
There was a problem hiding this comment.
Working through environment variables is more stable, since with the previous approach this module (driver.py) is loaded by Python at least twice (somewhere in Triton driver there is a manual module loading), which recreates CompilationHelper instance and removes the effect of calling inject_pytorch_dep method. This issue only occurs when trying to reuse make_launcher function, so the previous version still works correctly.
whitneywhtsang
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2540