Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make acc matrix allocation on each call for XeTLA GEMM benchmarks #3026

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

anmyachev
Copy link
Contributor

@anmyachev anmyachev commented Dec 17, 2024

If we take for comparison: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/12382880184/job/34564504020 (main) vs https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/12390456716/job/34585505155 (PR), then the degradation from this pull request for XeTLA is ~3%.

However, this is also a potential opportunity to improve the Triton kernel by only allocating the accumulation matrix once. If this is implemented for Triton, this pull request will need to be rolled back for XeTLA.

CI runs:

@anmyachev anmyachev changed the title Check influence of acc matrix allocation on GEMM benchmarks results Make acc matrix allocation on each call for XeTLA GEMM benchmarks Dec 18, 2024
@anmyachev
Copy link
Contributor Author

anmyachev commented Dec 18, 2024

Manual start, because for some reason the automatic one doesn't work: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/12392619525 (passed)

@anmyachev anmyachev marked this pull request as ready for review December 18, 2024 12:16
whitneywhtsang added a commit that referenced this pull request Dec 18, 2024
@anmyachev anmyachev merged commit 7eb41bf into main Dec 18, 2024
7 checks passed
@anmyachev anmyachev deleted the amyachev/debug-benchmarks branch December 18, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider make acc matrix allocation on each call for XeTLA GEMM benchmarks
2 participants