Unify Intel LLVM optimizations under lib/Target/LLVMIR #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbaden
force-pushed
the
alex/unify_intel_llvmir_processing
branch
from
951335f to
ae8e6f8
Compare
|
Rebased on #2775 - with this change all the Intel LLVM passes are in |
etiotto
reviewed
Dec 3, 2024
| @@ -1,7 +1,7 @@ | |||
| /// Trimmed down clone of llvm opt to be able to test triton custom llvm ir | |||
| /// passes. | |||
| #include "lib/Target/LLVMIR/LLVMPasses.h" | |||
| #include "third_party/intel/lib/LLVMIR/LLVMPasses.h" | |||
| #include "third_party/intel/lib/Target/LLVMIR/LLVMPasses.h" | |||
There was a problem hiding this comment.
I wonder if we really need to add this to this (common) makefile, it wasn't required for the PostProcessing library.
There was a problem hiding this comment.
PostProcessing does not test passes via lit test, but the FreezeMaskedLayout pass (which is now part of the same library) does.
alexbaden
force-pushed
the
alex/unify_intel_llvmir_processing
branch
2 times, most recently
from
caf261e to
18a084a
Compare
etiotto
approved these changes
Dec 5, 2024
| @@ -1,7 +1,7 @@ | |||
| /// Trimmed down clone of llvm opt to be able to test triton custom llvm ir | |||
| /// passes. | |||
| #include "lib/Target/LLVMIR/LLVMPasses.h" | |||
| #include "third_party/intel/lib/LLVMIR/LLVMPasses.h" | |||
| #include "third_party/intel/lib/Target/LLVMIR/LLVMPasses.h" | |||
whitneywhtsang
approved these changes
Dec 5, 2024
alexbaden
force-pushed
the
alex/unify_intel_llvmir_processing
branch
from
18a084a to
139df71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2775
I agree it would be nice to match upstream directory structure for our LLVM IR post processing passes - I've unified them here on top of the branch from 2775.