-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify folder for git clone in compile-pytorch-ipex.sh
; update IPEX pin
#2763
Conversation
Signed-off-by: Anatoly Myachev <[email protected]>
@@ -106,8 +106,7 @@ if [[ $BUILD_PYTORCH = true ]]; then | |||
rm -rf $PYTORCH_PROJ | |||
|
|||
echo "**** Cloning $PYTORCH_PROJ ****" | |||
cd $BASE | |||
git clone --single-branch -b dev/triton-test-3.0 --recurse-submodules --jobs 8 https://github.com/Stonepia/pytorch.git | |||
git clone --single-branch -b dev/triton-test-3.0 --recurse-submodules --jobs 8 https://github.com/Stonepia/pytorch.git $PYTORCH_PROJ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default was pytorch
Signed-off-by: Anatoly Myachev <[email protected]>
@Stonepia just to clarify, did you made force push to |
compile-pytorch-ipex.sh
compile-pytorch-ipex.sh
; update IPEX pin
@whitneywhtsang could you try with the last change? |
It passes the reported problem, it is at the step |
|
Oh sorry for that. Yes we made a force push to the dev/triton-test-3.0 branch, because there is a token leak, that should be our fault. We will fix that. |
Hi @anmyachev , I really apology for not informing you about the force push. Because I thought Triton had already switched to the stock PT. About this build problem specifically, I have checked about the code change, seems there is no change that would cause the break. I don't see anything that we missed. Most likely, is that during that version of IPEX, the CPU build would break the XPU version of IPEX. In addition, there might be because of the one API version. Could you try these things? I could build on my machine when the CPU part of IPEX is closed.
Again, so sorry for the issue. If there is anything I could help, please tell me. |
I didn't try to build with the former version of oneAPI (like 2023.2). I think the oneAPI version might explain why the former build could pass, and now it can't. From the code, I checked that and there should not have missing parts. |
Hi @Stonepia, thanks for confirming! Don't worry, it's not that bad. I was able to build code with PTDB, even with python 3.12.
@whitneywhtsang I can't reproduce that problem. If it's still there, I guess we can continue in a separate thread. |
Sure, my environment is Agama 1032.19, DLE 2025.0.0. |
Well, this is kind of expected, our IPEX branch doesn’t involve working with 2025 compiler, or I missed something? |
Make sense, verified it works for me with PTDB. |
Closes #2651