Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream LLVM location #2739

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Use upstream LLVM location #2739

merged 1 commit into from
Nov 18, 2024

Conversation

pbchekin
Copy link
Contributor

There is LLVM for CentOS in upstream again.
Fixes #2738.

@pbchekin pbchekin merged commit b7647ac into main Nov 18, 2024
4 checks passed
@pbchekin pbchekin deleted the 2738-upstream-llvm-location branch November 18, 2024 16:23
@anmyachev
Copy link
Contributor

@pbchekin should we update cache number in https://github.com/intel/intel-xpu-backend-for-triton/blame/229f7a1c10131a6736860e9f985e19c6dc57390f/.github/actions/setup-triton/action.yml#L27?

I noticed that locally in the resulted LLVM IR there is !llvm.dbg.cu = !{!4} instruction, but in LLVM IR from the CI it is not. My best guess is that we have slightly different builds, but I'm not 100% sure.

@pbchekin
Copy link
Contributor Author

@pbchekin should we update cache number in https://github.com/intel/intel-xpu-backend-for-triton/blame/229f7a1c10131a6736860e9f985e19c6dc57390f/.github/actions/setup-triton/action.yml#L27?

I noticed that locally in the resulted LLVM IR there is !llvm.dbg.cu = !{!4} instruction, but in LLVM IR from the CI it is not. My best guess is that we have slightly different builds, but I'm not 100% sure.

This cache is used only when building LLVM mode is enabled (if: ${{ inputs.build_llvm == 'true' }}). It is disabled by default and we download the LLVM package every time we build Triton. I think the issue somewhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert custom location for pre-build LLVM binaries
2 participants