Merge OpenAI Triton commit 76ed94d
#2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the dependence more obvious since `const std::string &target` is used in this file.
Minor changes that reuse Python's capabilities for writing platform-independent code. Signed-off-by: Anatoly Myachev <[email protected]>
This is a PR adding an attribute in the HIP backend to test for a tensor storage to be within 2GB. This will enable support of buffer operations.
This will make it easier to support other platforms downstream. I hope that such code should not complicate the support of Triton itself. --------- Signed-off-by: Anatoly Myachev <[email protected]>
Make `allow_reorder` and `efficient_layout` `UnitAttr` for a cleaner interface. This way, the operation exposes a `bool getEfficientLayout()` member to check for that attribute and a constructor receiving `bool` arguments for both of these attributes (defaulted to `false`). The core Triton is a small number of people, and we receive many PRs (thank you!). To help us review your code more quickly, **if you are a new contributor (less than 3 PRs merged) we ask that you complete the following tasks and include the filled-out checklist in your PR description.** Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. - [X] I am not making a trivial change, such as fixing a typo in a comment. - [X] I have written a PR description following these [rules](https://cbea.ms/git-commit/#why-not-how). - [X] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`. - Select one of the following. - [X] I have added tests. - `/test` for `lit` tests - `/unittest` for C++ tests - `/python/test` for end-to-end tests - [ ] This PR does not need a test because `FILL THIS IN`. - Select one of the following. - [ ] I have not added any `lit` tests. - [X] The `lit` tests I have added follow these [best practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices), including the "tests should be minimal" section. (Usually running Python code and using the instructions it generates is not minimal.) Signed-off-by: victor-eds <[email protected]>
We have flipped stream pipeliner v2 on as default for quite sometime. All known issues has been fixed. So now remove old v1 pipeliner. Note that this changes know `num_stages` are handled: previously we used to enable pipelining if `num_stages` is `0`, which really is not a good behavior. Now switched to follow common practice where `0`/`1` won't trigger pipelining anymore; need `2` or more to trigger. Given downstream users might be using `0` in the codebase, right now we `assert` to give developers a clear indication the switch of behavior instead of silently drop the perf. The `assert` is expected to be dropped sometime down the line. --------- Co-authored-by: Lei Zhang <[email protected]>
whitneywhtsang
force-pushed
the
whitneywhtsang/merge2
branch
from
3f456fa to
24bd5a6
Compare
etiotto
approved these changes
Oct 23, 2024
pbchekin
approved these changes
Oct 23, 2024
|
Trying a PyTorch Inductor run as this contains the commit that changes |
I reverted that commit, as it requires special handling, so this PR doesn't contain changes to |
|
I have started working on adapting to those changes in PyTorch as part of my effort to land the |
There are some unit test failures that require investigation, created #2544 to track it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change the Triton base from 185299e to 76ed94d (Oct 18).
Pass rate: 98.99%
Please do not squash and merge this PR.