Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable old GitHub workflow build_and_test #241

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

pbchekin
Copy link
Contributor

The new workflow (build_and_test_2) works in parallel with the old one and shows the same results in terms of PR verification. At the same time:

  • The old workflow does not scale, there is only one runner.
  • The old workflow uses a persistent runner which is prone to side effects (for example, updating llvm affects all future runs).

Note that to merge this PR we need to update repository branch rules to make the new workflow required and remove the old workflow from required checks for PR.

@pbchekin pbchekin marked this pull request as ready for review January 11, 2024 15:49
@whitneywhtsang
Copy link
Contributor

Note that to merge this PR we need to update repository branch rules to make the new workflow required and remove the old workflow from required checks for PR.

Let's change the required check from the old workflow to the new workflow now.

I would like to wait till next week to approve this PR, to give Ettore a chance to review the new workflow before disabling the old workflow. And also we can observe if there are any unexpected differences in behavior of the two workflows in the meantime.

@pbchekin
Copy link
Contributor Author

Let's change the required check from the old workflow to the new workflow now.

Done

@etiotto
Copy link
Contributor

etiotto commented Jan 15, 2024

I am OK with disable the old workflow (which was temporary anyway). Keep in mind though that eventually we should just run the upstream workflow here: https://github.com/openai/triton/blob/main/.github/workflows/integration-tests.yml

@etiotto
Copy link
Contributor

etiotto commented Jan 15, 2024

Given that we no longer need build_and_test.yml I think this PR should (a) remove that file and (b) rename build_and_test_2.yaml to build_and_test.yml (let's use the yml suffix given that OpenAI upstream is sticking to that suffix ?).

@pbchekin pbchekin merged commit 05bb46a into llvm-target Jan 16, 2024
3 checks passed
@pbchekin pbchekin deleted the deprecate-old-build-and-test branch January 16, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants