-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decompose large simdblockwrite
to smaller simdblockwrite
s
#2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Whitney Tsang <[email protected]>
Signed-off-by: Whitney Tsang <[email protected]>
Signed-off-by: Whitney Tsang <[email protected]>
Signed-off-by: Whitney Tsang <[email protected]>
Signed-off-by: Whitney Tsang <[email protected]>
Signed-off-by: Whitney Tsang <[email protected]>
Signed-off-by: Whitney Tsang <[email protected]>
CIs:
=> Results within the margin of error. |
whitneywhtsang
force-pushed
the
whitneywhtsang/splitsimdblockwrite
branch
4 times, most recently
from
September 13, 2024 04:10
beed1bd
to
128861d
Compare
whitneywhtsang
requested review from
etiotto,
quintinwang5,
Dewei-Wang-sh and
a team
September 13, 2024 04:11
victor-eds
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a minor NIT
etiotto
approved these changes
Sep 13, 2024
Signed-off-by: Whitney Tsang <[email protected]>
Signed-off-by: Whitney Tsang <[email protected]>
Base automatically changed from
whitneywhtsang/splitsimdblock
to
llvm-target
September 13, 2024 16:14
Signed-off-by: Whitney Tsang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #2193, but for
simdblockwrite
.Decompose
simdblockwrite
of vector size > 8 to a number ofsimdblockwrite
s of vector size 8.e.g.,
<64xi16>
simdblockwrite
is not supported by OpenCL C builtins, decompose it to8 x <8xi16>
.Restrict
TritonGEN::SIMDBlockWriteOp
to only accept vector types that are allowed by OpenCL C builtins.