add support for attention in match-target-size #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dewei-Wang-sh
force-pushed
the
attn_match
branch
2 times, most recently
from
d098a2b to
4f8d1bd
Compare
Dewei-Wang-sh
commented
Jul 4, 2024
Dewei-Wang-sh
force-pushed
the
attn_match
branch
2 times, most recently
from
7c2358e to
c03fa79
Compare
Dewei-Wang-sh
commented
Jul 9, 2024
Dewei-Wang-sh
commented
Jul 9, 2024
| "Attribute":$parent, | ||
| "unsigned":$kWidth, | ||
| "bool":$transpose), [{ | ||
| return $_get(context, opIdx, parent, kWidth, transpose); |
There was a problem hiding this comment.
add above so that existing upstream code in other .h .cpp do not need to change.
There was a problem hiding this comment.
created a new issue to track the upcoming refactor.
#1621
etiotto
reviewed
Jul 9, 2024
third_party/intel/lib/TritonIntelGPUTransforms/MatchTargetSize.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUTransforms/MatchTargetSize.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUTransforms/MatchTargetSize.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUTransforms/MatchTargetSize.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUTransforms/MatchTargetSize.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUTransforms/MatchTargetSize.cpp
Outdated
Show resolved
Hide resolved
etiotto
reviewed
Jul 9, 2024
third_party/intel/lib/TritonIntelGPUTransforms/MatchTargetSize.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/include/Dialect/TritonIntelGPU/IR/TritonIntelGPUOps.td
Show resolved
Hide resolved
third_party/intel/include/Dialect/TritonIntelGPU/IR/TritonIntelGPUOps.td
Outdated
Show resolved
Hide resolved
Signed-off-by: Tiotto, Ettore <[email protected]>
Dewei-Wang-sh
force-pushed
the
attn_match
branch
from
52a5fc3 to
2761ad7
Compare
etiotto
reviewed
Jul 11, 2024
third_party/intel/include/Dialect/TritonIntelGPU/IR/TritonIntelGPUOps.td
Outdated
Show resolved
Hide resolved
Signed-off-by: Tiotto, Ettore <[email protected]>
etiotto
reviewed
Jul 11, 2024
Signed-off-by: Tiotto, Ettore <[email protected]>
Signed-off-by: Tiotto, Ettore <[email protected]>
etiotto
reviewed
Jul 11, 2024
third_party/intel/include/Dialect/TritonIntelGPU/IR/TritonIntelGPUOps.td
Outdated
Show resolved
Hide resolved
… tests for the same operation Signed-off-by: Tiotto, Ettore <[email protected]>
etiotto
reviewed
Jul 11, 2024
etiotto
reviewed
Jul 11, 2024
third_party/intel/lib/TritonIntelGPUTransforms/MatchTargetSize.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUTransforms/MatchTargetSize.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUTransforms/MatchTargetSize.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUTransforms/MatchTargetSize.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Tiotto, Ettore <[email protected]>
etiotto
reviewed
Jul 11, 2024
etiotto
reviewed
Jul 11, 2024
Signed-off-by: Tiotto, Ettore <[email protected]>
Dewei-Wang-sh
commented
Jul 12, 2024
Dewei-Wang-sh
commented
Jul 12, 2024
victor-eds
reviewed
Jul 15, 2024
etiotto
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.