address review comments

intel · Dec 3, 2024 · dc9c16e · dc9c16e
1 parent ed6df23
commit dc9c16e
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/third_party/intel/lib/LLVMIR/LLVMIRFreezeMaskedDivRem.cpp b/third_party/intel/lib/LLVMIR/LLVMIRFreezeMaskedDivRem.cpp
@@ -6,16 +6,17 @@
 
 using namespace llvm;
 
-static bool processPhiNode(BasicBlock &BB, PHINode *PhiNode) {
-  if (!any_of(PhiNode->incoming_values(), [](Use &U) {
+static bool processPhiNode(PHINode *PhiNode) {
+  if (none_of(PhiNode->incoming_values(), [](Use &U) {
         Constant *C = dyn_cast<Constant>(&U);
         return isa<UndefValue>(U) || C && C->isNullValue();
       })) {
     return false;
   }
 
   bool Changed = false;
-  for (Instruction &I : BB) {
+  BasicBlock *BB = const_cast<BasicBlock *>(PhiNode->getParent());
+  for (Instruction &I : *BB) {
     if (I.getOpcode() == Instruction::SDiv ||
         I.getOpcode() == Instruction::SRem) {
       const size_t OpIdx = 1;
@@ -35,7 +36,7 @@ static bool runOnFunction(Function &F) {
 
   for (BasicBlock &BB : F) {
     for (PHINode &PhiNode : BB.phis()) {
-      Changed |= processPhiNode(BB, &PhiNode);
+      Changed |= processPhiNode(&PhiNode);
     }
   }