Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch all exceptions and convert them to errors #51

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Catch all exceptions and convert them to errors #51

merged 1 commit into from
Feb 8, 2024

Conversation

Pennycook
Copy link
Contributor

Related issues

Partial fix for #25.

Proposed changes

  • Wrap the entire codebasin script in a try/except block to catch all exceptions.
  • Forward exception messages to the logger and display them as errors.

@Pennycook Pennycook added the enhancement New feature or request label Feb 8, 2024
@Pennycook Pennycook added this to the 1.2.0 milestone Feb 8, 2024
@Pennycook Pennycook merged commit fe807dc into intel:main Feb 8, 2024
1 check passed
@Pennycook Pennycook deleted the exception-handling branch February 8, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laserkelvin laserkelvin laserkelvin approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Pennycook @laserkelvin