Add support for exclude patterns #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exclude_patterns replaces the exclude_files option, allowing the use of git-style "pathspec"s in place of globs. This may seem like a small change, but it's very powerful, allowing patterns as simple as "*.ext" to exclude ALL files with a particular extension. Signed-off-by: John Pennycook <[email protected]>
Acts as a shorthand for defining exclude patterns in a YAML configuration file. Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
laserkelvin
requested changes
Feb 5, 2024
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
laserkelvin
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exclude_patternsreplaces theexclude_filesoption, allowing the use of git-style "pathspec"s in place of globs. This may seem like a small change, but it's very powerful, allowing patterns as simple as "*.ext" to exclude ALL files with a particular extension.This PR also adds a
--excludeoption to the codebasin script that exposes the same functionality without having to modify the YAML configuration file, which is both more convenient and more aligned with our long-term direction.The functionality here is 99% of the work for supporting a
.cbiignorefile in the source directory (which basically acts as an implicit list of exclude patterns) but I wanted to keep that separate to simplify review of the base functionality.