Refactor usage of args (excluding *args) to argv

[itsjayway]

#28

Please advise if changes in main...itsjayway:code-base-investigator:main#diff-1b77d714cd5303809e8b061199c6146dc9dc66bb03443f8e27a25598b2411143R56-R61

or
main...itsjayway:code-base-investigator:main#diff-971c35bb84781bea01e028040afd4f1df63231ceca66defde899193a2375db15R99

are necessary, or if 5229969 was sufficient.

[Pennycook]

Thank you again for working on this.

I didn't appreciate that we had a few different conventions for args here -- thank you for being thorough and looking for them all! I think there are a few cases here where renaming things to argv isn't appropriate; I've convinced myself that it only makes sense to use argv as a name when the variable is a list of strings representing a command (like one would get from sys.argv).

I've gone through the changes and highlighted cases where I think we should revert to args in keeping with the logic above. @laserkelvin, could you also take a quick look to see if you agree that this convention makes sense?

Code changes aside, it would be great if you could also:

• Rebase to remove the first two (unused) commits
• Amend the commit to include a sign-off (with git commit -s)

I suspect it would be easiest to do both of these things at the same time, by squashing everything into one (signed) commit. You can do that without opening a new pull request, by making your changes locally and then force-pushing to the same branch.

[itsjayway]

thank you for your feedback. I've pushed a commit that keeps the argv changes where they relate to commands.

I'm not sure how I erased my commit history, but hopefully this change is appropriate

[Pennycook]

thank you for your feedback. I've pushed a commit that keeps the argv changes where they relate to commands.

Thanks, @itsjayway. The changes look good now.

I'm not sure how I erased my commit history, but hopefully this change is appropriate

Don't worry about erasing the commit history -- we wanted that to happen, to get rid of the revert commit and other work-in-progress commits.

But I'm afraid I'm going to need to ask you to rebase and force push one more time because of our contributing guidelines. Specifically:

• The coding conventions require different formatting for your commit message.
• You need to sign your work before we can accept the contribution.

To give you an idea of what we're looking for, something like the below would be appropriate:

Refactor usage of args to argv

Applies only to commands accepting a list of string arguments.

Signed-off-by: Your Name <[email protected]>

[Pennycook]

Thank you for contributing! 🎉