Switch to per-module loggers #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shouldn't change any behavior, because all loggers in the codebasin package will inherit its configuration. However, having separate loggers will allow us to configure different behavior for each module later. Signed-off-by: John Pennycook <[email protected]>
The documentation for the logging module says that the disabled property of a logger should be treated as read-only. The logging.disable() function is the correct way to disable logging. Signed-off-by: John Pennycook <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Pre-work for #108.
Switching to per-module loggers (which are best practice anyway) will allow us to separate preprocessor-related messages.
Proposed changes
__name__to give each module its own logger.disabledproperty of each logger. Settingdisableddirectly is not allowed (see here) and doesn't propagate to child loggers.