-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
releasenote.md: cleanup and fixes #71
Open
esyr-rh
wants to merge
10
commits into
intel:main
Choose a base branch
from
esyr-rh:microcode-20230808-releasenote-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its usage has been started in microcode-20230214 (and only in the "Updated Platforms" section entries, not in the "New Platforms" one (up to microcode-20230808) or section headers) and is quite baffling, as it is visually indistinguishable from a space character (and this patch is a testament to that), serves no discernible purpose, but (poorly) thwarts attempts to programmatically parse and compare the release notes, and pollutes any copy-pasted text. Signed-off-by: Eugene Syromiatnikov <[email protected]>
The notes for the last two releases contain some trailing spaces in random places that seemingly serve no particular purpose. Signed-off-by: Eugene Syromiatnikov <[email protected]>
Starting with microcode-20220809, the first-level "Release Notes" header is duplicated for unknown reason; remove it, as it does not make sense to have it multiple times in the middle of the document, consider the fact that first-level header is usually reserved for the document name (and it seems that it indeed bears that role). * releasenote.md: Remove all "Release Notes" headers after the first one. Signed-off-by: Eugene Syromiatnikov <[email protected]>
…cally microcode-20230214 seemingly (but not fully; the "New Platforms" section still have used the old sorting order) have switched the entries order from sorting on the FF-MM-SS/PI field to sorting on the Codename field (which is arguably significantly less useful and much more confusing, especially in cases of CPUIDs spanning several code names, such as 06-8e-0[9ac]). However, it is impossible to devise the sorting order of the entries in the microcode-20230808 changelog table, which makes it even more difficult to navigate, so this patch just changes it to the lastly used one. Signed-off-by: Eugene Syromiatnikov <[email protected]>
microcode-20230214, microcode-20230512, and microcode-20230512-rev2 release notes state that the platform mask for CPUIDs with FF-MM-SS 06-ba-02 and 06-ba-03 is 0x07, but it is, in fact, 0xc0: $ iucode_tool -L microcode-20230{214,512,512-rev2}/intel-ucode/06-ba-0[23] microcode bundle 1: microcode-20230214/intel-ucode/06-ba-02 001/001: sig 0x000b06a2, pf_mask 0xc0, 2022-12-08, rev 0x410e, size 212992 sig 0x000b06a2, pf_mask 0xc0, 2022-12-08, rev 0x410e sig 0x000b06a3, pf_mask 0xc0, 2022-12-08, rev 0x410e microcode bundle 2: microcode-20230214/intel-ucode/06-ba-03 002/001: sig 0x000b06a2, pf_mask 0xc0, 2022-12-08, rev 0x410e, size 212992 sig 0x000b06a2, pf_mask 0xc0, 2022-12-08, rev 0x410e sig 0x000b06a3, pf_mask 0xc0, 2022-12-08, rev 0x410e microcode bundle 3: microcode-20230512/intel-ucode/06-ba-02 003/001: sig 0x000b06a2, pf_mask 0xc0, 2023-02-22, rev 0x4112, size 212992 sig 0x000b06a2, pf_mask 0xc0, 2023-02-22, rev 0x4112 sig 0x000b06a3, pf_mask 0xc0, 2023-02-22, rev 0x4112 microcode bundle 4: microcode-20230512/intel-ucode/06-ba-03 004/001: sig 0x000b06a2, pf_mask 0xc0, 2023-02-22, rev 0x4112, size 212992 sig 0x000b06a2, pf_mask 0xc0, 2023-02-22, rev 0x4112 sig 0x000b06a3, pf_mask 0xc0, 2023-02-22, rev 0x4112 microcode bundle 5: microcode-20230512-rev2/intel-ucode/06-ba-02 005/001: sig 0x000b06a2, pf_mask 0xc0, 2023-02-22, rev 0x4112, size 212992 sig 0x000b06a2, pf_mask 0xc0, 2023-02-22, rev 0x4112 sig 0x000b06a3, pf_mask 0xc0, 2023-02-22, rev 0x4112 microcode bundle 6: microcode-20230512-rev2/intel-ucode/06-ba-03 006/001: sig 0x000b06a2, pf_mask 0xc0, 2023-02-22, rev 0x4112, size 212992 sig 0x000b06a2, pf_mask 0xc0, 2023-02-22, rev 0x4112 sig 0x000b06a3, pf_mask 0xc0, 2023-02-22, rev 0x4112 Also, fix incorrect RPL-U stepping in the microcode-20230214 table. * releasenote.md (microcode-20230214, microcode-20230512, microcode-20230512-rev2) <RPL-H 6+8, RPL-P 6+8>: Change the F-M-S field from 06-ba-02/07 to 06-ba-02/c0. (microcode-20230214) <RPL-U 2+8>: Change the F-M-S field from 06-ba-02/07 to 06-ba-03/c0. (microcode-20230512, microcode-20230512-rev2) <RPL-U 2+8>: Change the F-M-S field from 06-ba-03/07 to 06-ba-03/c0. Signed-off-by: Eugene Syromiatnikov <[email protected]>
microcode-20221108, microcode-20230214, microcode-20230512, and microcode-20230512-rev2 release notes (incorrectly) state RPL-S (06-b7-01/32) stepping as S0, while microcode-20230808 release notes state it as B0, and [1] confirms the correctness of the latter. [1] "13th Generation Intel Core Processors. Datasheet, Volume 1 of 2" Rev. 005, February 2023, section 15.0 "CPU And Device IDs" https://cdrdv2-public.intel.com/743844/743844-005.pdf * releasenote.md (microcode-20221108, microcode-20230214, microcode-20230512, microcode-20230512-rev2) <RPL-S>: Change the stepping field value from "S0" to "B0". Signed-off-by: Eugene Syromiatnikov <[email protected]>
microcode-20230808 release notes for CPUIDs 06-ba-02/e0 (RPL-H/P/PX 6+8), 06-ba-03/e0 (RPL-U 2+8), and 06-be-00/11 (ADL-N) are peculiar in a way that these CPUIDs have their PF mask values changed (from 06-ba-02/c0, 06-ba-03/c0, and 06-be-00/01, respectively). Since 06-ba-02/e0 and 06-be-00/11 are listed both in "New Platforms" and "Updated Platforms" sections (which makes some sense, as it is both addition of the platform 0x10 and update for the rest of the platforms), it is natural to assume that this is done this way on purpose, and that 06-ba-03/e0 of these three is accidentally missing from the "New Platforms" section. * releasenote.md (microcode-20230808) <New Platforms>: Add 06-ba-03/e0 (RPL-U 2+8) entry. Signed-off-by: Eugene Syromiatnikov <[email protected]>
CFL-S stepping P0 (06-9e-0c/22) is already listed as "CFL-H/S" and it has not been listed in the notes to the previous releases separately. * releasenote.md (microcode-20230808) <CFL-S P0>: Remove. Signed-off-by: Eugene Syromiatnikov <[email protected]>
…ries The values provided are from the microcode-20230214 release, even though they have been updated in microcode-20230512. Curiously, only one entry of two with CPUID of 06-55-04/b7 has manifested this mistake. * releasenote.md (microcode-20230808) <AML-Y22 H0>: Change the "Old Ver" field from 000000f0 to 000000f2. (microcode-20230808) <SKX-SP H0/M0/U0>: Change the "Old Ver" field from 02006e05 to 02006f05. Signed-off-by: Eugene Syromiatnikov <[email protected]>
…6-ba-03/e0 As has been mentioned already in commit "releasenote.md: add missing 06-ba-03/e0 to the new microcode section", platforms with CPUIDs 06-be-00, 06-ba-02, and 06-ba-03 have their platform mask changed and thusly listed in both "New Platforms" and "Updated Platforms" sections of microcode-20230808 release notes. It is, however, puzzling to have the "Old Ver" field of these entries empty in the "Updated Platforms" section, so it seemingly make sense to populate it with the previous microcode versions for the existing platforms. * releasenote.md (microcode-20230808) <Updated Platforms>: Provide 00000010 as the "Old Ver" field value for ADL-N A0 (06-be-00/11, nee 06-be-00/01); provide 00004112 as the "Old Ver" field value for RPL-H/P/PX 6+8 J0 (06-ba-02/e0, nee 06-ba-02/c0) and RPL-U 2+8 Q0 (06-ba-03/e0, nee 06-ba-03/c0). Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr-rh
changed the title
releasenot.md: cleanup and fixes
releasenote.md: cleanup and fixes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set does some cleanup to releasenote.md and fixes various inaccuracies in recent release notes: