Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Centralize docker networks #92

Merged
merged 4 commits into from
Oct 30, 2023
Merged

fix: Centralize docker networks #92

merged 4 commits into from
Oct 30, 2023

Conversation

seanohair22
Copy link
Contributor

PR Checklist

  • Added label to the Pull Request for easier discoverability and search
  • Commit Message meets guidelines as indicated in the URL https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
  • Every commit is a single defect fix and does not mix feature addition or changes
  • Unit Tests have been added for new changes
  • Updated Documentation as relevant to the changes
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with repository license and clearly outlined the added dependency.
  • PR change contains code related to security
  • PR introduces changes that breaks compatibility with other modules (If YES, please provide details below)

What are you changing?

Issue this PR will close

close: #90
closes: #90

Anything the reviewer should know when reviewing this PR?

Test Instructions if applicable

  • Optional: Run make run-portainer
  • Run make run-base or run-full and check the docker networks that are setup.
  • Note: Portainer runs on a separate docker network in order to spin up and take down the RTSF services easily and still use Portainer.

If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/rtsf-at-checkout-reference-design )

@seanohair22 seanohair22 added enhancement New feature or request dependencies Pull requests that update a dependency file labels Oct 24, 2023
@seanohair22 seanohair22 self-assigned this Oct 24, 2023
@seanohair22 seanohair22 linked an issue Oct 24, 2023 that may be closed by this pull request
Centralize docker networks on project #90
Closed
lenny-goodell
lenny-goodell reviewed Oct 25, 2023
View reviewed changes
loss-detection-app/docker-compose.loss-detection.yml Outdated
Comment on lines 20 to 21
name: loss-detection-app_edgex-network
driver: bridge
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this working with the network defined in the edgex compose file?

lenny-goodell
lenny-goodell approved these changes Oct 25, 2023
View reviewed changes
Copy link

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marcpfuller
marcpfuller approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@marcpfuller marcpfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jim-wang-intel
jim-wang-intel approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanohair22 seanohair22 merged commit aec1428 into intel-retail:EdgeX-3.0 Oct 30, 2023
9 checks passed
@seanohair22 seanohair22 deleted the EdgeX-3.0-centralize-networks branch October 30, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcpfuller marcpfuller marcpfuller approved these changes

@lenny-goodell lenny-goodell lenny-goodell approved these changes

@jim-wang-intel jim-wang-intel jim-wang-intel approved these changes

@NeethuES-intel NeethuES-intel Awaiting requested review from NeethuES-intel

@presatish presatish Awaiting requested review from presatish

@vli11 vli11 Awaiting requested review from vli11

@brian-intel brian-intel Awaiting requested review from brian-intel

@ejlee3 ejlee3 Awaiting requested review from ejlee3

Assignees

@seanohair22 seanohair22

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Centralize docker networks on project
4 participants
@seanohair22 @jim-wang-intel @lenny-goodell @marcpfuller