Skip to content

Commit

Permalink
mm: Convert do_set_pte() to set_pte_range()
Browse files Browse the repository at this point in the history
set_pte_range() allows to setup page table entries for a specific
range.  It takes advantage of batched rmap update for large folio.
It now takes care of calling update_mmu_cache().

Signed-off-by: Yin Fengwei <[email protected]>
Signed-off-by: Matthew Wilcox (Oracle) <[email protected]>
  • Loading branch information
fyin1 authored and intel-lab-lkp committed Feb 7, 2023
1 parent 8b224c9 commit 4e6eb35
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 16 deletions.
2 changes: 1 addition & 1 deletion Documentation/filesystems/locking.rst
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,7 @@ locked. The VM will unlock the page.
Filesystem should find and map pages associated with offsets from "start_pgoff"
till "end_pgoff". ->map_pages() is called with page table locked and must
not block. If it's not possible to reach a page without blocking,
filesystem should skip it. Filesystem should use do_set_pte() to setup
filesystem should skip it. Filesystem should use set_pte_range() to setup
page table entry. Pointer to entry associated with the page is passed in
"pte" field in vm_fault structure. Pointers to entries for other offsets
should be calculated relative to "pte".
Expand Down
3 changes: 2 additions & 1 deletion include/linux/mm.h
Original file line number Diff line number Diff line change
Expand Up @@ -1168,7 +1168,8 @@ static inline pte_t maybe_mkwrite(pte_t pte, struct vm_area_struct *vma)
}

vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page);
void do_set_pte(struct vm_fault *vmf, struct page *page, unsigned long addr);
void set_pte_range(struct vm_fault *vmf, struct folio *folio,
struct page *page, unsigned int nr, unsigned long addr);

vm_fault_t finish_fault(struct vm_fault *vmf);
vm_fault_t finish_mkwrite_fault(struct vm_fault *vmf);
Expand Down
3 changes: 1 addition & 2 deletions mm/filemap.c
Original file line number Diff line number Diff line change
Expand Up @@ -3375,8 +3375,7 @@ static vm_fault_t filemap_map_folio_range(struct vm_fault *vmf,
ret = VM_FAULT_NOPAGE;

ref_count++;
do_set_pte(vmf, page, addr);
update_mmu_cache(vma, addr, vmf->pte);
set_pte_range(vmf, folio, page, 1, addr);
} while (vmf->pte++, page++, addr += PAGE_SIZE, ++count < nr_pages);

/* Restore the vmf->pte */
Expand Down
31 changes: 19 additions & 12 deletions mm/memory.c
Original file line number Diff line number Diff line change
Expand Up @@ -4257,15 +4257,18 @@ vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page)
}
#endif

void do_set_pte(struct vm_fault *vmf, struct page *page, unsigned long addr)
void set_pte_range(struct vm_fault *vmf, struct folio *folio,
struct page *page, unsigned int nr, unsigned long addr)
{
struct vm_area_struct *vma = vmf->vma;
bool uffd_wp = pte_marker_uffd_wp(vmf->orig_pte);
bool write = vmf->flags & FAULT_FLAG_WRITE;
bool prefault = vmf->address != addr;
pte_t entry;
unsigned int i;

flush_icache_page(vma, page);
for (i = 0; i < nr; i++)
flush_icache_page(vma, page + i);
entry = mk_pte(page, vma->vm_page_prot);

if (prefault && arch_wants_old_prefaulted_pte())
Expand All @@ -4279,14 +4282,20 @@ void do_set_pte(struct vm_fault *vmf, struct page *page, unsigned long addr)
entry = pte_mkuffd_wp(entry);
/* copy-on-write page */
if (write && !(vma->vm_flags & VM_SHARED)) {
inc_mm_counter(vma->vm_mm, MM_ANONPAGES);
page_add_new_anon_rmap(page, vma, addr);
lru_cache_add_inactive_or_unevictable(page, vma);
add_mm_counter(vma->vm_mm, MM_ANONPAGES, nr);
VM_BUG_ON_FOLIO(nr != 1, folio);
folio_add_new_anon_rmap(folio, vma, addr);
folio_add_lru_vma(folio, vma);
} else {
inc_mm_counter(vma->vm_mm, mm_counter_file(page));
page_add_file_rmap(page, vma, false);
add_mm_counter(vma->vm_mm, mm_counter_file(page), nr);
folio_add_file_rmap_range(folio, page, nr, vma, false);
}
set_pte_at(vma->vm_mm, addr, vmf->pte, entry);
set_ptes(vma->vm_mm, addr, vmf->pte, entry, nr);

/* no need to invalidate: a not-present page won't be cached */
for (i = 0; i < nr; i++)
update_mmu_cache(vma, addr + i * PAGE_SIZE, vmf->pte + i);

}

static bool vmf_pte_changed(struct vm_fault *vmf)
Expand Down Expand Up @@ -4359,11 +4368,9 @@ vm_fault_t finish_fault(struct vm_fault *vmf)

/* Re-check under ptl */
if (likely(!vmf_pte_changed(vmf))) {
do_set_pte(vmf, page, vmf->address);

/* no need to invalidate: a not-present page won't be cached */
update_mmu_cache(vma, vmf->address, vmf->pte);
struct folio *folio = page_folio(page);

set_pte_range(vmf, folio, page, 1, vmf->address);
ret = 0;
} else {
update_mmu_tlb(vma, vmf->address, vmf->pte);
Expand Down

0 comments on commit 4e6eb35

Please sign in to comment.