Skip to content

Commit

Permalink
pinctrl: aspeed: Fix confusing types in return value
Browse files Browse the repository at this point in the history
The function signature is int, but we return a bool. Instead return a
negative errno as the kerneldoc suggests.

Fixes: 4d3d0e4 ("pinctrl: Add core support for Aspeed SoCs")
Signed-off-by: Joel Stanley <[email protected]>
Reviewed-by: Andrew Jeffery <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Linus Walleij <[email protected]>
  • Loading branch information
shenki authored and linusw committed Jan 27, 2023
1 parent 5754a1c commit 287a344
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/pinctrl/aspeed/pinctrl-aspeed.c
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ static int aspeed_disable_sig(struct aspeed_pinmux_data *ctx,
int ret = 0;

if (!exprs)
return true;
return -EINVAL;

while (*exprs && !ret) {
ret = aspeed_sig_expr_disable(ctx, *exprs);
Expand Down

0 comments on commit 287a344

Please sign in to comment.