Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Modelscope option for chatglm3 on GPU #12545

Merged
merged 6 commits into from
Dec 16, 2024

Conversation

ATMxsp01
Copy link
Contributor

@ATMxsp01 ATMxsp01 commented Dec 13, 2024

It is a test pr for a list of models which is to add modelscope options

This option for chatglm3 has been tested in linux platform with A770 GPU

update: This option has been tested win platform with A770 GPU

@Oscilloscope98 Oscilloscope98 self-requested a review December 13, 2024 09:47
Copy link
Contributor

@Oscilloscope98 Oscilloscope98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the 1st paragraph in README to include modelscope model repo id

@Oscilloscope98
Copy link
Contributor

@jason-dai Please let us know for any comments on this template PR for adding modelscope options to GPU examples. Thank you :)

P.S. Would it be a little strange that the updated examples are under HuggingFace/LLM folder?

@Oscilloscope98 Oscilloscope98 changed the title Add Modelscope option for GPU model chatglm3 Add Modelscope option for chatglm3 on GPU Dec 16, 2024
@Oscilloscope98
Copy link
Contributor

Merged for now. Will raise further PRs for any comments :)

@Oscilloscope98 Oscilloscope98 merged commit ccc18ee into intel-analytics:main Dec 16, 2024
1 check passed
@ATMxsp01 ATMxsp01 deleted the modelscope-chatglm3 branch December 17, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants