Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] refactor clippy tests and fix clippy CI OOM #1470

Merged
merged 10 commits into from
Oct 13, 2023
Merged

[CI] refactor clippy tests and fix clippy CI OOM #1470

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e2efd04
[GHA] refactor clippy CI and fix clippy OOM
clangenb Oct 13, 2023
443272c
[GHA] remove copy-pasted doc
clangenb Oct 13, 2023
afb3a7b
[GHA] fix yaml syntax
clangenb Oct 13, 2023
36eba31
[GHA] fix yaml syntax 2
clangenb Oct 13, 2023
20e44f9
[GHA] fmt
clangenb Oct 13, 2023
fa34ab4
[GHA] fix test matrix
clangenb Oct 13, 2023
715ce57
[GHA] update test naming
clangenb Oct 13, 2023
2e77069
[GHA] free diskspace before running clippy
clangenb Oct 13, 2023
3a78238
[GHA] remove freeing diskspace as it doesn't have any effect
clangenb Oct 13, 2023
92eb59d
[GHA] is --release mode for clippy as the CI runs out of space otherw…
clangenb Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 40 additions & 44 deletions .github/workflows/build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,56 +125,52 @@ jobs:
fi
docker images --all

clippy:
code-quality:
runs-on: ubuntu-latest
container: "integritee/integritee-dev:0.2.2"
strategy:
fail-fast: false
matrix:
check: [
# Worker
# Use release mode as the CI runs out of disk space otherwise.
cargo clippy --release -- -D warnings,
cargo clippy --release --features evm -- -D warnings,
cargo clippy --release --features sidechain -- -D warnings,
cargo clippy --release --features teeracle -- -D warnings,
cargo clippy --release --features offchain-worker -- -D warnings,

# Enclave
cd enclave-runtime && cargo clippy -- -D warnings,
cd enclave-runtime && cargo clippy --features evm -- -D warnings,
cd enclave-runtime && cargo clippy --features sidechain -- -D warnings,
cd enclave-runtime && cargo clippy --features teeracle -- -D warnings,
cd enclave-runtime && cargo clippy --features offchain-worker -- -D warnings,

# Fmt
cargo fmt --all -- --check,
cd enclave-runtime && cargo fmt --all -- --check,
]
steps:
- uses: actions/checkout@v3
- name: init rust
# enclave is not in the same workspace
- name: init-rust-target
# Enclave is not in the same workspace
run: rustup show && cd enclave-runtime && rustup show

- name: Clippy default features
run: cargo clippy -- -D warnings
- name: Enclave # Enclave is separate as it's not in the workspace
run: cd enclave-runtime && cargo clippy -- -D warnings

- name: Clippy with EVM feature
run: |
cargo clippy --features evm -- -D warnings
cd enclave-runtime && cargo clippy --features evm -- -D warnings

- name: Clippy with Sidechain feature
run: |
cargo clippy --features sidechain -- -D warnings
cd enclave-runtime && cargo clippy --features sidechain -- -D warnings

- name: Clippy with Teeracle feature
run: |
cargo clippy --features teeracle -- -D warnings
cd enclave-runtime && cargo clippy --features teeracle -- -D warnings

- name: Clippy with Offchain-worker feature
run: |
cargo clippy --features offchain-worker -- -D warnings
cd enclave-runtime && cargo clippy --features offchain-worker -- -D warnings
- uses: Swatinem/rust-cache@v2
with:
key: ${{ matrix.check }}

- name: Fail-fast; cancel other jobs
if: failure()
uses: andymckay/[email protected]
- name: ${{ matrix.check }}
run: ${{ matrix.check }}

fmt:
toml-fmt:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: init rust
run: rustup show

- name: Worker & Client
run: cargo fmt --all -- --check
- name: Enclave # Enclave is separate as it's not in the workspace
run: cd enclave-runtime && cargo fmt --all -- --check

- name: Install taplo
run: cargo install taplo-cli --locked
- name: Cargo.toml fmt
Expand Down Expand Up @@ -362,7 +358,7 @@ jobs:
runs-on: integritee-builder-sgx
name: Release Build of teeracle
if: startsWith(github.ref, 'refs/tags/')
needs: [build-test, integration-tests]
needs: [ build-test, integration-tests ]

strategy:
fail-fast: false
Expand Down Expand Up @@ -436,8 +432,8 @@ jobs:

- name: Save released teeracle
run: |
docker image save integritee/${{ matrix.flavor_id }}:${{ github.ref_name }} | gzip > integritee-worker-${{ matrix.flavor_id }}-${{ github.ref_name }}.tar.gz
docker images --all
docker image save integritee/${{ matrix.flavor_id }}:${{ github.ref_name }} | gzip > integritee-worker-${{ matrix.flavor_id }}-${{ github.ref_name }}.tar.gz
docker images --all

- name: Upload teeracle image
uses: actions/upload-artifact@v3
Expand All @@ -447,16 +443,16 @@ jobs:

- name: Delete images
run: |
if [[ "$(docker images -q integritee/${{ matrix.flavor_id }}:${{ github.ref_name }} 2> /dev/null)" != "" ]]; then
docker image rmi --force integritee/${{ matrix.flavor_id }}:${{ github.ref_name }} 2>/dev/null
fi
docker images --all
if [[ "$(docker images -q integritee/${{ matrix.flavor_id }}:${{ github.ref_name }} 2> /dev/null)" != "" ]]; then
docker image rmi --force integritee/${{ matrix.flavor_id }}:${{ github.ref_name }} 2>/dev/null
fi
docker images --all

release:
runs-on: ubuntu-latest
name: Draft Release
if: startsWith(github.ref, 'refs/tags/')
needs: [build-test, integration-tests, release-build]
needs: [ build-test, integration-tests, release-build ]
outputs:
release_url: ${{ steps.create-release.outputs.html_url }}
asset_upload_url: ${{ steps.create-release.outputs.upload_url }}
Expand Down