Skip to content
This repository has been archived by the owner on Sep 6, 2024. It is now read-only.

Commit

Permalink
Fix the GitHub Actions tag pattern
Browse files Browse the repository at this point in the history
GitHub Actions branch and tag pattern matching doesn't have full regex support.
Documentation on filter patterns can be found here:
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

Also move the publish conditional from the step to the job.
  • Loading branch information
peterkuczera committed May 14, 2024
1 parent b557a0d commit 1f6d6d0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
branches:
- main
tags:
- "v[0-9]+.[0-9]+.[0-9]$"
- "v[0-9]+.[0-9]+.[0-9]+"
paths-ignore:
- "**/*.md"
- LICENSE
Expand Down Expand Up @@ -248,6 +248,7 @@ jobs:
INTEGRATIONOS_TESTING_MODEL: ${{ secrets.INTEGRATIONOS_TESTING_MODEL }}
publish:
name: Publish
if: ${{ startsWith(github.ref, 'refs/tags/') }}
runs-on: ubuntu-latest
needs:
- test-macOS-windows-binding
Expand All @@ -272,7 +273,6 @@ jobs:
run: ls -R ./npm
shell: bash
- name: Publish
if: ${{ startsWith(github.ref, 'refs/tags/') }}
run: |
echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" >> ~/.npmrc
npm publish --access public
Expand Down

0 comments on commit 1f6d6d0

Please sign in to comment.