Fix calendar not loading when calendar context limit is increased #2991
Conversation
refs: MBL-18102 affects: Student, Teacher, Parent release note: Fixed calendar not displaying the filter list and events properly. test plan: - Enable "Increase calendar context limit" in course settings on web. - Go to all apps, check if calendar loads. - Check if calendar filter loads, pull to refresh doesn't show an error page. - Test if teacher app still has a functioning calendar filter (max 10/20 events).
vargaat
requested review from
szabinst,
rh12,
ndrsszsz and
suhaibabsi-inst
as code owners
vargaat
changed the title
Parent Build QR Code: |
Teacher Build QR Code: |
Student Build QR Code: |
Release Note:Fixed calendar not displaying the filter list and events properly. Affected Apps: Student, Teacher, Parent
|
| case .extended(let value): return value | ||
| case .unlimited: return 9999 | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public extension Optional where Wrapped == AppEnvironment.App { |
There was a problem hiding this comment.
I noticed that on this extension, if we haveisCalendarFilterLimitEnabled always evaluated to false for Student app. I am wondering whether we need for Student or Parent apps to still worry about parsing this property.
There was a problem hiding this comment.
Not really, I also thought about this but left it as-is to save some time but it would be a nice future improvement.
There was a problem hiding this comment.
QA + 1
Code + 1
Thanks @vargaat !
But I have few concerns for you to consider.
| @@ -17,7 +17,9 @@ | |||
| // | |||
|
|
|||
| public struct GetEnvironmentSettingsRequest: APIRequestable { | |||
| public typealias Response = [String: Bool] | |||
| public struct Response: Codable { | |||
| public let calendar_contexts_limit: Int? | |||
There was a problem hiding this comment.
Can we say the it is confirmed the BE team will continue using this for future?
Or, perhaps, would be better to keep a logic to check for the Bool value as well? (The old way).
What changed?
/api/v1/settings/environment.json: thecalendar_contexts_limitfield no longer returns a bool whether it's enabled or not but returns the actual limit as an integer in case theIncrease calendar context limittoggle is enabled. If this setting is not enabled the API won't return this field at all.refs: MBL-18102
affects: Student, Teacher, Parent
release note: Fixed calendar not displaying the filter list and events properly.
test plan:
Checklist