Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue of user not being able to submit assignment when logged in root account #2989

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

suhaibabsi-inst
Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst commented Nov 27, 2024

refs: MBL-18064
affects: Student,Teacher
release note: Fixes issue of user not being able to submit assignment when logged in root account

What's changed

The main point of change of this PR resides in files:
AppEnvironmentOverride
GenericCellViewModel

This is to provide a clean way to pass a modified AppEnvironment with the correct baseURL that fits the current tab user is sitting at, which in this case is Course > Assignments

The rest are a consequence of those changes, which is basically to make sure views and classes are respecting what ever AppEnvironment instance is passed to them.

Test Plan

See ticket description.

Also, made testing for ordinary accounts for following use cases:

  1. View Assignment details
  2. View Submission details
  3. New text and file assignment submission.
  4. New text and file submission comment.
  5. View submission comments, especially those with comments.

Screen Record

demo_consortia.mov

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

…root account

refs: MBL-18064
affects: Student
release note: Fixes issue of user not being able to submit assignment when logged in root account
@inst-danger
Copy link
Contributor

inst-danger commented Nov 27, 2024

Warnings
⚠️ One or more files are below the minimum test coverage 50%
⚠️ The total test coverage is below the minimum 90%

Release Note:

Fixes issue of user not being able to submit assignment when logged in root account

Affected Apps: Student, Teacher

MBL-18064

Coverage New % Master % Delta
Canvas iOS 89.89% 90.15% -0.26%
Core/Core/AppEnvironment/AppEnvironmentOverride.swift 6.06% -- --
Core/Core/Planner/CalendarMain/ViewModel/PlannerViewModel.swift 0% 0% 0%
Core/Core/Planner/CalendarMain/Model/CalendarWeek.swift 0% 0% 0%
Core/Core/Extensions/CGSizeExtensions.swift 0% -- --
Core/Core/Planner/CalendarMain/View/Calendar/CalendarCardInteractionState.swift 0% 0% 0%
Core/Core/Planner/CalendarMain/Model/PlannablesInteractor.swift 0% 0% 0%
Core/Core/Search/Model/SearchSupportButtonModel.swift 0% -- --
Core/Core/Planner/CalendarMain/View/Calendar/ViewPreferences.swift 0% 0% 0%
Core/Core/Planner/CalendarMain/Model/CalendarDay.swift 0% 0% 0%
Core/Core/Courses/SmartSearch/View/CourseSmartSearchViewsProvider.swift 13.64% -- --

Generated by 🚫 dangerJS against e8ee852

@inst-danger
Copy link
Contributor

inst-danger commented Nov 27, 2024

Student Build QR Code:

@suhaibabsi-inst suhaibabsi-inst marked this pull request as ready for review November 27, 2024 14:55
@suhaibabsi-inst suhaibabsi-inst marked this pull request as draft November 27, 2024 15:24
refs: MBL-18064
affects: Student,Teacher
release note: Fixes issue of user not being able to submit assignment when logged in root account
@inst-danger
Copy link
Contributor

inst-danger commented Nov 27, 2024

Teacher Build QR Code:

@suhaibabsi-inst suhaibabsi-inst marked this pull request as ready for review November 27, 2024 21:24
@balintbartok balintbartok marked this pull request as draft November 29, 2024 13:08
@suhaibabsi-inst suhaibabsi-inst marked this pull request as ready for review December 1, 2024 11:57
@suhaibabsi-inst suhaibabsi-inst marked this pull request as draft December 1, 2024 11:57
@suhaibabsi-inst suhaibabsi-inst marked this pull request as ready for review December 2, 2024 08:48
@suhaibabsi-inst suhaibabsi-inst marked this pull request as draft December 2, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants