-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue of user not being able to submit assignment when logged in root account #2989
Draft
suhaibabsi-inst
wants to merge
6
commits into
master
Choose a base branch
from
bugfix/MBL-18064-Consortia-Submission
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+721
−244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…root account refs: MBL-18064 affects: Student release note: Fixes issue of user not being able to submit assignment when logged in root account
7 tasks
Release Note:Fixes issue of user not being able to submit assignment when logged in root account Affected Apps: Student, Teacher
|
suhaibabsi-inst
requested review from
vargaat,
szabinst,
rh12 and
ndrsszsz
as code owners
November 27, 2024 14:55
refs: MBL-18064 affects: Student,Teacher release note: Fixes issue of user not being able to submit assignment when logged in root account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: MBL-18064
affects: Student,Teacher
release note: Fixes issue of user not being able to submit assignment when logged in root account
What's changed
The main point of change of this PR resides in files:
AppEnvironmentOverride
GenericCellViewModel
This is to provide a clean way to pass a modified
AppEnvironment
with the correct baseURL that fits the current tab user is sitting at, which in this case isCourse > Assignments
The rest are a consequence of those changes, which is basically to make sure views and classes are respecting what ever
AppEnvironment
instance is passed to them.Test Plan
See ticket description.
Also, made testing for ordinary accounts for following use cases:
Screen Record
demo_consortia.mov
Checklist