Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix pyright unnecessary type ignore comment #1266

Closed
wants to merge 1 commit into from

Conversation

ivanleomk
Copy link
Collaborator

@ivanleomk ivanleomk commented Dec 18, 2024

Important

Remove unnecessary # type: ignore comments from pydantic imports and adjust formatting in several files.

  • Type Ignore Removal:
    • Removed # type: ignore from pydantic imports in batch.py, citation.py, iterable.py, maybe.py, validators.py, and multimodal.py.
  • Formatting:
    • Added trailing commas in dictionary definitions in batch.py and iterable.py.
    • Removed unnecessary line breaks in multimodal.py.

This description was created by Ellipsis for b07286c. It will automatically update as commits are pushed.

Copy link

Deploying instructor-py with  Cloudflare Pages  Cloudflare Pages

Latest commit: b07286c
Status: ✅  Deploy successful!
Preview URL: https://6336b970.instructor-py.pages.dev
Branch Preview URL: https://fix-pyright-ignore-errors.instructor-py.pages.dev

View logs

@ivanleomk ivanleomk closed this Dec 18, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b07286c in 2 minutes and 16 seconds

More details
  • Looked at 169 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. instructor/batch.py:6
  • Draft comment:
    Unnecessary trailing comma in the dictionary definition. Remove it for cleaner code.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR removes unnecessary type ignore comments for pydantic imports. This is a good change as it cleans up the code. However, there are some formatting issues that need to be addressed.
2. instructor/dsl/iterable.py:115
  • Draft comment:
    Unnecessary trailing comma in the set definition. Remove it for cleaner code.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR removes unnecessary type ignore comments for pydantic imports. This is a good change as it cleans up the code. However, there are some formatting issues that need to be addressed.
3. instructor/multimodal.py:343
  • Draft comment:
    Unnecessary trailing comma in the list definition. Remove it for cleaner code.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR removes unnecessary type ignore comments for pydantic imports. This is a good change as it cleans up the code. However, there are some formatting issues that need to be addressed.
4. instructor/batch.py:3
  • Draft comment:
    Since the pydantic import has been modified, please ensure that the relevant documentation and tests are updated accordingly.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_NgJqD43tKNjRP2CH


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@github-actions github-actions bot added enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant