-
-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sambanova integration #1244
base: main
Are you sure you want to change the base?
Feature/sambanova integration #1244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to b4eb16a in 1 minute and 12 seconds
More details
- Looked at
495
lines of code in12
files - Skipped
0
files when reviewing. - Skipped posting
6
drafted comments based on config settings.
1. instructor/__init__.py:101
- Draft comment:
Remove the unnecessary print statement.
- Reason this comment was not posted:
Confidence changes required:50%
The print statement 'sambanova' in the init.py file is unnecessary and should be removed.
2. docs/blog/posts/open_source.md:239
- Draft comment:
Assertions should include an error message for clarity and debugging purposes. This applies to the assertion on line 239 and similar assertions elsewhere in the code. - Reason this comment was not posted:
Confidence changes required:80%
The assertion statements in the code lack error messages, which is against the rule that assertions should always have an error message.
3. docs/examples/sambanova.md:54
- Draft comment:
Assertions should include an error message for clarity and debugging purposes. This applies to the assertion on line 54 and similar assertions elsewhere in the code. - Reason this comment was not posted:
Confidence changes required:80%
The assertion statements in the code lack error messages, which is against the rule that assertions should always have an error message.
4. docs/integrations/sambanova.md:60
- Draft comment:
Assertions should include an error message for clarity and debugging purposes. This applies to the assertion on line 60 and similar assertions elsewhere in the code. - Reason this comment was not posted:
Confidence changes required:80%
The assertion statements in the code lack error messages, which is against the rule that assertions should always have an error message.
5. examples/sambanova/sambanova_example.py:29
- Draft comment:
Assertions should include an error message for clarity and debugging purposes. This applies to the assertion on line 29 and similar assertions elsewhere in the code. - Reason this comment was not posted:
Confidence changes required:80%
The assertion statements in the code lack error messages, which is against the rule that assertions should always have an error message.
6. instructor/__init__.py:101
- Draft comment:
Remove the unnecessary print statement to clean up the code. - Reason this comment was not posted:
Confidence changes required:80%
The print statement on line 101 seems unnecessary and could be removed to clean up the code.
Workflow ID: wflow_l4ysQYQhLiPNl6xv
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
hey @jxnl could you help us with this integration please? Thanks in advance. |
Important
Add SambaNova Cloud integration for structured outputs with documentation and examples.
from_sambanova()
function inclient_sambanova.py
to integrate SambaNova Cloud with Instructor.__init__.py
to includefrom_sambanova
in available imports.SAMBANOVA
toProvider
enum inutils.py
.docs/integrations/sambanova.md
.docs/index.md
anddocs/integrations/index.md
to include SambaNova.docs/examples/sambanova.md
andexamples/sambanova/sambanova_example.py
.parse_tools()
infunction_calls.py
to handle dict arguments by converting them to JSON strings.This description was created by for b4eb16a. It will automatically update as commits are pushed.