Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding type ignore for pyright #1215

Merged
merged 1 commit into from
Nov 24, 2024
Merged

fix: adding type ignore for pyright #1215

merged 1 commit into from
Nov 24, 2024

Conversation

ivanleomk
Copy link
Collaborator

@ivanleomk ivanleomk commented Nov 24, 2024

Important

Add type ignore comments for pyright in _make_field_optional() in partial.py.

  • Type Ignore Comments:
    • Added # type: ignore to tmp_field.annotation = Optional[field.annotation] in _make_field_optional().
    • Added # type: ignore to return tmp_field.annotation, tmp_field in _make_field_optional().

This description was created by Ellipsis for d06f540. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d06f540 in 17 seconds

More details
  • Looked at 17 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. instructor/dsl/partial.py:109
  • Draft comment:
    Add a space after '#' for consistency.
        tmp_field.annotation = Optional[field.annotation]  # type: ignore
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The type ignore comments should have a space after the '#' for consistency and readability.
2. instructor/dsl/partial.py:112
  • Draft comment:
    Add a space after '#' for consistency.
    return tmp_field.annotation, tmp_field  # type: ignore
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The type ignore comments should have a space after the '#' for consistency and readability.

Workflow ID: wflow_UQQI0S396gObUQi6


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@github-actions github-actions bot added enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 24, 2024
Copy link

Deploying instructor-py with  Cloudflare Pages  Cloudflare Pages

Latest commit: d06f540
Status: ✅  Deploy successful!
Preview URL: https://0d68ac13.instructor-py.pages.dev
Branch Preview URL: https://fix-pyright-partial.instructor-py.pages.dev

View logs

@ivanleomk ivanleomk merged commit d49abe7 into main Nov 24, 2024
15 of 16 checks passed
@ivanleomk ivanleomk deleted the fix-pyright-partial branch November 24, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant