Support nested generics with partial

[mwildehahn]

See the test case for an example of where this was failing before. This adds support for handling any level of nesting for generic types.

---

Important

Adds support for nested generics in Partial class with new _process_generic_arg() function and updates tests for verification.

• Behavior:
  • Adds support for nested generics in Partial class by introducing _process_generic_arg() in partial.py.
  • Handles any level of nesting for generic types like Union, List, Dict.
  • Special handling for Union types with types.UnionType for Python 3.10+.
• Tests:
  • Adds test_union_with_nested() in test_partial.py to verify nested generics handling.
  • Updates existing tests to ensure compatibility with new nested generics support.

^{This description was created by for c9be3ba. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to c9be3ba in 1 minute and 11 seconds

More details

• Looked at 165 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. tests/dsl/test_partial.py:189

• Draft comment:
  The test test_union_with_nested lacks an assertion to verify the expected behavior. Consider adding an assertion to ensure the Partial model behaves as expected.
• Reason this comment was not posted:
  Confidence changes required: 80%
  The test case test_union_with_nested is missing an assertion to verify the expected behavior of the Partial model. Without an assertion, the test does not confirm the correctness of the code.

2. instructor/dsl/partial.py:50

• Draft comment:
  Add comments to _process_generic_arg to explain its logic, especially since it deals with complex type manipulations.
• Reason this comment was not posted:
  Confidence changes required: 80%
  The function _process_generic_arg is a new addition to handle nested generics, but it lacks comments explaining its logic, especially since it deals with complex type manipulations.

3. instructor/dsl/partial.py:81

• Draft comment:
  Add comments to _make_field_optional to explain its logic, especially since it deals with complex type manipulations.
• Reason this comment was not posted:
  Confidence changes required: 80%
  The function _make_field_optional is modified to use _process_generic_arg, but it lacks comments explaining its logic, especially since it deals with complex type manipulations.

4. instructor/dsl/partial.py:392

• Draft comment:
  Add comments to _wrap_models to explain its logic, especially since it deals with complex type manipulations.
• Reason this comment was not posted:
  Confidence changes required: 80%
  The function _wrap_models is modified to use _process_generic_arg, but it lacks comments explaining its logic, especially since it deals with complex type manipulations.

Workflow ID: wflow_WpQzbHuk6UcXE1U3

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.