-
-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Writer integration #1167
feat: Writer integration #1167
Conversation
…ntire item at the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to f28b4a4 in 46 seconds
More details
- Looked at
1073
lines of code in18
files - Skipped
1
files when reviewing. - Skipped posting
7
drafted comments based on config settings.
1. docs/blog/posts/writer-support.md:80
- Draft comment:
There's a typo in the word 'meetingis'. It should be 'meeting is'. - Reason this comment was not posted:
Confidence changes required:10%
The blog post contains a minor typo in the word 'meetingis'.
2. instructor/client_writer.py:30
- Draft comment:
The return type annotation should includeinstructor.AsyncInstructor
for the case when the client is an instance ofAsyncWriter
. - Reason this comment was not posted:
Confidence changes required:50%
Thefrom_writer
function ininstructor/client_writer.py
should returninstructor.AsyncInstructor
when the client is an instance ofAsyncWriter
. The return type annotation should reflect this possibility.
3. instructor/dsl/iterable.py:112
- Draft comment:
Consider refactoring theextract_json
andextract_json_async
methods to avoid code duplication, as they have similar logic for handling different modes. - Reason this comment was not posted:
Confidence changes required:30%
Theextract_json
andextract_json_async
methods ininstructor/dsl/iterable.py
andinstructor/dsl/partial.py
have similar logic for handling different modes. This could be refactored to avoid code duplication.
4. instructor/dsl/partial.py:246
- Draft comment:
Consider refactoring theextract_json
andextract_json_async
methods to avoid code duplication, as they have similar logic for handling different modes. - Reason this comment was not posted:
Confidence changes required:30%
Theextract_json
andextract_json_async
methods ininstructor/dsl/iterable.py
andinstructor/dsl/partial.py
have similar logic for handling different modes. This could be refactored to avoid code duplication.
5. instructor/function_calls.py:316
- Draft comment:
Ensuretool_calls
is not empty before accessing its elements to avoid potential assertion errors. - Reason this comment was not posted:
Confidence changes required:50%
Theparse_writer_tools
method ininstructor/function_calls.py
should handle cases wheretool_calls
might be empty to avoid assertion errors.
6. docs/blog/posts/writer-support.md:1
- Draft comment:
Please ensure this new markdown file is added to themkdocs.yml
to be included in the documentation. - Reason this comment was not posted:
Confidence changes required:80%
The new markdown file should be added to the mkdocs.yml for documentation purposes.
7. instructor/dsl/partial.py:154
-
Draft comment:
The methodwriter_model_from_chunks_async
is functionally similar tomodel_from_chunks_async
. Consider extendingmodel_from_chunks_async
to handle any specific variations needed. -
method
model_from_chunks_async
(partial.py) -
Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_NeZ1fYCYeyiKTdDa
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Describe your changes
Add implementation of Writer AI provider
Issue ticket number and link
Issue #1165
Checklist before requesting a review
Important
Add integration with Writer AI provider, including new modes, functions, and tests for structured outputs and enterprise AI workflows.
from_writer()
function inclient_writer.py
to initialize Writer client withWriter
andAsyncWriter
.__init__.py
to includefrom_writer
ifwriterai
is available.WRITER_TOOLS
mode inmode.py
.parse_writer_tools()
infunction_calls.py
to handle Writer tool calls.process_response.py
to handleWRITER_TOOLS
mode.handle_writer_tools()
inprocess_response.py
for processing Writer tool responses.reask.py
to includereask_writer_tools()
for handling re-asks in Writer mode.writer-support.md
indocs/blog/posts
to announce Writer integration.tests/llm/test_writer/
for various functionalities including format handling, retries, and streaming.conftest.py
to configure Writer API key for tests.writer-sdk
topyproject.toml
as an optional dependency.This description was created by for f28b4a4. It will automatically update as commits are pushed.