Remove incorrect e2e implementation #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg S <[email protected]>
RobotSail
force-pushed
the
remove-e2e-2-the-electric-boogaloo
branch
from
6ee4eb3 to
ecc289e
Compare
RobotSail
changed the title
|
Why was spellcheck removed here? That has nothing to do with E2E |
Testing the user end-to-end instructlab workflow is the point of this workflow. It will give you an early indication if your changes to the library break the CLI. Sometimes that might be on purpose, but in case it's not, it will let you know before you publish a release. This is not intended to replace other functional testing aimed at the library more directly, but the full end-to-end workflow is important. I'm OK if you want to disable it for the moment, but it needs to go back on at some point. A better way to do that is to just edit the workflow to turn it off instead of removing it from the repo. |
This was referenced Jun 26, 2024
Closed
russellb
added a commit
to russellb/instructlab-training
that referenced
this pull request
Jun 26, 2024
This reverts commit ebc5e31 from instructlab#76. Here is my comment on instructlab#76 that better explains how this workflow fits in to the bigger picture: > Testing the user end-to-end instructlab workflow is the point of > this workflow. It will give you an early indication if your changes to > the library break the CLI. Sometimes that might be on purpose, but in > case it's not, it will let you know before you publish a release. > > This is not intended to replace other functional testing aimed at the > library more directly, but the full end-to-end workflow is important. > > I'm OK if you want to disable it for the moment, but it needs to go > back on at some point. A better way to do that is to just edit the > workflow to turn it off instead of removing it from the repo. Issue instructlab#63 Signed-off-by: Russell Bryant <[email protected]>
russellb
added a commit
to russellb/instructlab-training
that referenced
this pull request
Jun 27, 2024
This reverts commit ebc5e31 from instructlab#76. Here is my comment on instructlab#76 that better explains how this workflow fits in to the bigger picture: > Testing the user end-to-end instructlab workflow is the point of > this workflow. It will give you an early indication if your changes to > the library break the CLI. Sometimes that might be on purpose, but in > case it's not, it will let you know before you publish a release. > > This is not intended to replace other functional testing aimed at the > library more directly, but the full end-to-end workflow is important. > > I'm OK if you want to disable it for the moment, but it needs to go > back on at some point. A better way to do that is to just edit the > workflow to turn it off instead of removing it from the repo. The previous commit also removed spellcheck (though it wasn't mentioned). I have left it out in this PR. Issue instructlab#63 Signed-off-by: Russell Bryant <[email protected]>
russellb
added a commit
to russellb/instructlab-training
that referenced
this pull request
Jun 28, 2024
This reverts commit ebc5e31 from instructlab#76. Here is my comment on instructlab#76 that better explains how this workflow fits in to the bigger picture: > Testing the user end-to-end instructlab workflow is the point of > this workflow. It will give you an early indication if your changes to > the library break the CLI. Sometimes that might be on purpose, but in > case it's not, it will let you know before you publish a release. > > This is not intended to replace other functional testing aimed at the > library more directly, but the full end-to-end workflow is important. > > I'm OK if you want to disable it for the moment, but it needs to go > back on at some point. A better way to do that is to just edit the > workflow to turn it off instead of removing it from the repo. The previous commit also removed spellcheck (though it wasn't mentioned). I have left it out in this PR. Issue instructlab#63 Signed-off-by: Russell Bryant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're removing the end-to-end test because these rely on the implementation of ilab.
What we want instead is to have e2e tests that are based solely on the code of this repository, and not a separate tool consuming instructlab-training internally.
Fixes #74