Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metric): model trigger table records api #507

Merged
merged 1 commit into from
Nov 4, 2024
Merged

feat(metric): model trigger table records api #507

merged 1 commit into from
Nov 4, 2024

Conversation

joremysh
Copy link
Contributor

@joremysh joremysh commented Nov 4, 2024 •
edited
Loading

Because

  • dashboard needs API for model trigger count

This commit

  • add new metrics API

@linear Linear
Copy link

linear bot commented Nov 4, 2024

INS-6757 model trigger table records api

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedNov 4, 2024, 3:39 AM

@joremysh joremysh merged commit 359b6fd into main Nov 4, 2024
14 checks passed
@joremysh joremysh deleted the jeremy/ins-6757-model-trigger-table-records-api branch November 4, 2024 03:45
@droplet-bot droplet-bot mentioned this pull request Nov 4, 2024
Open
joremysh added a commit that referenced this pull request Nov 4, 2024
@joremysh
Revert "feat(metric): model trigger table records api (#507)"
8543e27 
This reverts commit 359b6fd.
@joremysh joremysh mentioned this pull request Nov 4, 2024
Merged
donch1989 pushed a commit that referenced this pull request Nov 4, 2024
@joremysh
feat(metric): revert "model trigger table records api" (#508)
edb1c96 
Reverts #507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 donch1989 approved these changes

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joremysh @donch1989