Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blob,catalog): add external_metadata field and correct the comment #504

Merged
merged 3 commits into from
Oct 29, 2024
Merged

feat(blob,catalog): add external_metadata field and correct the comment #504

merged 3 commits into from
Oct 29, 2024

Conversation

Yougigun
Copy link
Contributor

@Yougigun Yougigun commented Oct 29, 2024 •
edited
Loading

Because:

  1. We will support users attaching metadata to uploaded files.
  2. The URL should support a non-expiring mode.

This commit:

  1. Adds external_metadata in the file message.
  2. Allows url_expire to be set to 0, meaning it does not expire.

ref: ins-6685

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 29, 2024, 12:47 PM

@Yougigun Yougigun force-pushed the gary/add-external-filed-modify-the-blob branch from 2eb36bc to a7d4cb0 Compare October 29, 2024 12:47
@linear Linear
Copy link

linear bot commented Oct 29, 2024

INS-6685 feat - add external_file filed in `message File` in protobuf repo

chuang8511
chuang8511 reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@chuang8511 chuang8511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ask a question

artifact/artifact/v1alpha/artifact.proto Show resolved Hide resolved
@Yougigun Yougigun merged commit 3cc5fbe into main Oct 29, 2024
1 check passed
@Yougigun Yougigun deleted the gary/add-external-filed-modify-the-blob branch October 29, 2024 16:26
@droplet-bot droplet-bot mentioned this pull request Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuang8511 chuang8511 chuang8511 left review comments

@heiruwu heiruwu heiruwu approved these changes

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yougigun @heiruwu @chuang8511 @droplet-bot