Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(integration): correct integrationId filter documentation #483

Merged
merged 5 commits into from
Oct 4, 2024
Merged

fix(integration): correct integrationId filter documentation #483

merged 5 commits into from
Oct 4, 2024

Conversation

jvallesm
Copy link
Collaborator

@jvallesm jvallesm commented Oct 4, 2024

Because

  • Example in this filter param contains the old snake_case format.

This commit

  • Update documentation with a correct example.

@jvallesm jvallesm self-assigned this Oct 4, 2024
@jvallesm jvallesm marked this pull request as ready for review October 4, 2024 10:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 4, 2024, 10:31 AM

@jvallesm jvallesm force-pushed the jvalles/fix-integration-filter-doc branch from 62e5e64 to 5d858b9 Compare October 4, 2024 10:31
@jvallesm
Copy link
Collaborator Author

jvallesm commented Oct 4, 2024

Before / after

CleanShot 2024-10-04 at 12 50 31
CleanShot 2024-10-04 at 12 50 24

@jvallesm jvallesm merged commit 3a2124a into main Oct 4, 2024
@jvallesm jvallesm deleted the jvalles/fix-integration-filter-doc branch October 4, 2024 10:51
@droplet-bot droplet-bot mentioned this pull request Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees

@jvallesm jvallesm

Labels
None yet
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvallesm @droplet-bot