Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app): remove conversation uid and add conversation struct #471

Merged
merged 5 commits into from
Sep 26, 2024
Merged

feat(app): remove conversation uid and add conversation struct #471

merged 5 commits into from
Sep 26, 2024

Conversation

Yougigun
Copy link
Contributor

@Yougigun Yougigun commented Sep 26, 2024 •
edited
Loading

Because

  1. app AI assistant does not need the unique app anymore.
  2. we need to return more info for conversation object.

This commit

  1. removes the filed
  2. adds conversation object in response

@linear Linear
Copy link

linear bot commented Sep 26, 2024

INS-6356 feat - user can have own conversation under same app(AI assistant)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedSep 26, 2024, 12:01 PM

@Yougigun Yougigun force-pushed the gary/ins-6356-remove-conv-in-metadata branch from f037b91 to 8a95f8c Compare September 26, 2024 12:00
@Yougigun Yougigun changed the title feat(app): remove conversation uid in metadata feat(app): remove conversation uid and add conversation struct Sep 26, 2024
@Yougigun Yougigun merged commit 7765049 into main Sep 26, 2024
12 checks passed
@Yougigun Yougigun deleted the gary/ins-6356-remove-conv-in-metadata branch September 26, 2024 14:46
@droplet-bot droplet-bot mentioned this pull request Sep 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiruwu heiruwu heiruwu approved these changes

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yougigun @heiruwu @droplet-bot