Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(artifact): support csv file type #458

Merged
merged 3 commits into from
Sep 20, 2024
Merged

feat(artifact): support csv file type #458

merged 3 commits into from
Sep 20, 2024

Conversation

Yougigun
Copy link
Contributor

@Yougigun Yougigun commented Sep 20, 2024 •
edited
Loading

Because

  1. document component is going to support csv and xls
  2. Ask & Retrieve API lakcs Instill-Requester-Uid header information

This commit

  1. add file type in API spec
  2. add Instill-Requester-Uid header info in protobuf

@linear Linear
Copy link

linear bot commented Sep 20, 2024

INS-6267 [Improvement][Catalog BE] Support for .csv & .xls File Types

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedSep 20, 2024, 12:42 AM

@heiruwu heiruwu merged commit 35cfcdf into main Sep 20, 2024
1 check passed
@heiruwu heiruwu deleted the gary/ins-6267-support-csv-xls branch September 20, 2024 05:44
@droplet-bot droplet-bot mentioned this pull request Sep 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiruwu heiruwu heiruwu approved these changes

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yougigun @heiruwu @droplet-bot