Skip to content

Commit

Permalink
fix(metric): fix path conflicts with existing wildcard in gin (#510)
Browse files Browse the repository at this point in the history
Because

- using colons in url paths will cause conflicts either in krakend or
gin

This commit

- replace colons with `/`

---------

Co-authored-by: droplet-bot <[email protected]>
  • Loading branch information
joremysh and droplet-bot authored Nov 4, 2024
1 parent 0b47096 commit 0bc2591
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions core/mgmt/v1beta/mgmt_public_service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ service MgmtPublicService {
// Returns the model trigger count of a given requester within a timespan.
// Results are grouped by trigger status.
rpc GetModelTriggerCount(GetModelTriggerCountRequest) returns (GetModelTriggerCountResponse) {
option (google.api.http) = {get: "/v1beta/model-runs:count"};
option (google.api.http) = {get: "/v1beta/model-runs/count"};
option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = {
tags: "📊 Metrics"
extensions: {
Expand Down Expand Up @@ -528,7 +528,7 @@ service MgmtPublicService {
// response will contain one set of records (datapoints), representing the
// amount of triggers in a time bucket.
rpc ListModelTriggerChartRecords(ListModelTriggerChartRecordsRequest) returns (ListModelTriggerChartRecordsResponse) {
option (google.api.http) = {get: "/v1beta/model-runs:query-charts"};
option (google.api.http) = {get: "/v1beta/model-runs/query-charts"};
option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = {
tags: "📊 Metrics"
extensions: {
Expand Down
2 changes: 1 addition & 1 deletion openapi/v2/service.swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2214,7 +2214,7 @@ paths:
tags:
- "\U0001F4CA Metrics"
x-stage: beta
/v1beta/model-runs:query-charts:
/v1beta/model-runs/query-charts:
get:
summary: List model trigger time charts
description: |-
Expand Down

0 comments on commit 0bc2591

Please sign in to comment.