Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(recipe): support required attribute for variable #901

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

donch1989
Copy link
Member

Because

  • we want users to explicitly define which variables are required.

This commit

  • adds support for the required attribute in variables.

Copy link

linear bot commented Dec 2, 2024

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 20.02%. Comparing base (86bffe8) to head (1b94258).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
pkg/service/pipeline.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #901      +/-   ##
==========================================
+ Coverage   19.97%   20.02%   +0.04%     
==========================================
  Files         409      409              
  Lines       83418    83474      +56     
==========================================
+ Hits        16666    16712      +46     
- Misses      64320    64328       +8     
- Partials     2432     2434       +2     
Flag Coverage Δ
unittests 20.02% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donch1989 donch1989 merged commit da7f0e9 into main Dec 2, 2024
14 checks passed
@donch1989 donch1989 deleted the huitang/ins-7034 branch December 2, 2024 14:36
donch1989 pushed a commit that referenced this pull request Dec 3, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.48.0-beta](v0.47.2-beta...v0.48.0-beta)
(2024-12-03)


### Features

* **component,data,base:** enhance component features
([#885](#885))
([68b396f](68b396f))
* **component,googlesheet:** implement the Google Sheet component
([#878](#878))
([8a0ab93](8a0ab93))
* **component,instillapp:** remove instill-app component
([#911](#911))
([4a7c970](4a7c970))
* **component,openai:** support streaming for o1-mini and o1-preview
models
([#882](#882))
([367e957](367e957))
* **component,schedule:** introduce the `schedule` component
([#900](#900))
([9582942](9582942))
* **connection:** add lookup connection endpoint
([#888](#888))
([86bffe8](86bffe8))
* **data:** add support for default value in `instill` Go tag
([#891](#891))
([b9c2d05](b9c2d05))
* **leadiq:** implement leadiq component
([#874](#874))
([78c2ec7](78c2ec7))
* **perplexity:** add perplexity component
([#861](#861))
([1fc7dbe](1fc7dbe))
* **recipe:** separate the template and the rendered value for input and
setup
([#886](#886))
([3ec3dd6](3ec3dd6))
* **recipe:** support `required` attribute for variable
([#901](#901))
([da7f0e9](da7f0e9))
* **service:** add the file extension to the output filename
([#873](#873))
([22b92b0](22b92b0))
* **service:** trigger latest release version for pipeline with
run-on-event setting
([#896](#896))
([0b1c071](0b1c071))
* **smartlead:** implement smartlead
([#879](#879))
([f6baf2a](f6baf2a))
* **text:** improve markdown chunking
([#889](#889))
([d48b3ec](d48b3ec))
* **trigger:** accept connection references in the pipeline trigger data
([#883](#883))
([937bd01](937bd01))
* **trigger:** enable optional values for variables
([#884](#884))
([187f5fd](187f5fd))
* **vdp:** skip google drive for cloud version
([#899](#899))
([5089397](5089397))


### Bug Fixes

* **ci:** use xk6-sql driver and pin down versions
([#876](#876))
([1f64d6c](1f64d6c))
* **component,openai:** enable the use of system messages with chat
history
([#905](#905))
([ef3e66f](ef3e66f))
* **leadiq, smartlead:** change field to optional
([#892](#892))
([9bd995d](9bd995d))
* **web:** fix url and markdown position
([#893](#893))
([af8f412](af8f412))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants