-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(auth): fix Auth0 integration #164
Conversation
Signed-off-by: Tobias Cudnik <[email protected]>
Signed-off-by: Tobias Cudnik <[email protected]>
Signed-off-by: Tobias Cudnik <[email protected]>
- .env for local dev - aligned build system - instill-dev.eu tenant working Signed-off-by: Tobias Cudnik <[email protected]>
INS-1575 CLI v2
In-progress design doc for CLI v2
|
Signed-off-by: Tobias Cudnik <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
==========================================
+ Coverage 50.10% 50.13% +0.02%
==========================================
Files 48 48
Lines 3702 3700 -2
==========================================
Hits 1855 1855
+ Misses 1676 1674 -2
Partials 171 171
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
a8d33d7
to
340106d
Compare
340106d
to
3cbac71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Because - `instill auth login` isnt working This commit - missing auth0 vars - .env for local dev - updated go version - aligned build system - aligned CI - dev and prod tenants working - fix callback error Ticket: https://linear.app/instill-ai/issue/INS-1660/cli-fix-auth-for-cloud-prod ### Testing 1. Create an `.env` file and fill in the secrets ``` # SECRETS # vault / secret / devops / auth0 / prod / client-id INSTILL_OAUTH_CLIENT_ID= # vault / secret / devops / auth0 / prod / client-secret INSTILL_OAUTH_CLIENT_SECRET= # CONFIG INSTILL_OAUTH_HOSTNAME=auth.instill.tech INSTILL_OAUTH_ISSUER=https://auth.instill.tech/ INSTILL_OAUTH_AUDIENCE=https://api.instill.tech INSTILL_OAUTH_CALLBACK_HOST=localhost INSTILL_OAUTH_CALLBACK_PORT=8085 ``` 2. `make bin/instill` 3. `./bin/instill auth login` ### Future work - integration tests with Auth0 - auth for Core instances Co-authored-by: Ping-Lin Chang <[email protected]>
Because
instill auth login
isnt workingThis commit
Ticket: https://linear.app/instill-ai/issue/INS-1660/cli-fix-auth-for-cloud-prod
Testing
.env
file and fill in the secretsmake bin/instill
./bin/instill auth login
Future work