-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #21, Chrome Auto-fill Issue #22
base: master
Are you sure you want to change the base?
Conversation
…fill Conflicts: dist/react-maskedinput.js
@fuelpagan could you rebase master and add a test case for this scenario? |
sure will |
says there are 5 steps to the rebase and having issues with number 2... |
Can you fix the conflict easy enough? I would guess because |
Hey there, I'm also interested in this patch! However, I noticed that the |
@Cybrass onChange event isn’t being fired by the browser or by this library? We should be emulating whatever React would do so the behavior is seamless. |
Is this dead? Running into this issue right now and need to get it fixed. |
I can create a new PR if this is not going to be merged 🤔 |
issue #21
When using the chrome auto-fill feature with mask pattern (111) 111-1111, I found it was firing the _onChange function. By calling this.mask.setValue(e.target.value) before calling this._getDisplayValue() I was able the have the input fill in properly using (234) 234-2342 as well as 2342342342, both filled in correctly with this change.
When pasting, the this.mask.paste(e.clipboardData.getData('Text')) was returning false. With 2342342342 the underlying inputmask-core would return false comparing 2 to (. When pasting (234) 234-2342, inputmask-core would return false when comparing ) with the mask pattern looking for a number. Adding
allowed pasting numeric values to work. I also tested with alpha characters and the paste still rejected as expected.