Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with react 15.4.0 #76

Closed
ldabiralai opened this issue Nov 16, 2016 · 17 comments
Closed

Incompatibility with react 15.4.0 #76

ldabiralai opened this issue Nov 16, 2016 · 17 comments

Comments

@ldabiralai
Copy link

React 15.4.0 has been released which removes a lot of the internals, specifically around ReactInputSelection which causes 3.3.0 to break. Saw this had been remedied in the latest commits though.

It would be good to get this released soon as it's likely a lot of people will be upgrading in the next few days.

Thanks 👍

@yocontra
Copy link

ERROR in ./~/react-maskedinput/lib/index.js
Module not found: Error: Cannot resolve module 'react/lib/ReactInputSelection' in /Users/contra/Projects/staeco/node_modules/react-maskedinput/lib
 @ ./~/react-maskedinput/lib/index.js 9:15-55

@rfviolato
Copy link

👍

I was about to open the same issue!

@pixelfuture
Copy link

Getting the same error when upgrading to react v15.4

@imchuck
Copy link

imchuck commented Nov 16, 2016

Hope you fix this issue soon 👍

@benitocas88
Copy link

We have the same problem!!! Help

@radoi90
Copy link

radoi90 commented Nov 16, 2016

It was fixed two days ago, the commit is there but no release. What gives?

@sarcastron
Copy link

Not sure if it helps anyone else. I was having the same issue and got around it by changing dependencies back to 15.03.

{
    "react": "~15.3.1",
    "react-dom": "~15.3.1"
}

Basically switched the ^ to ~.

I noticed that the commit looks like it fixes it, but it didn't seem to work if I forced npm to pull from git repo instead of NPM.

@markbrouch
Copy link

I'm seeing the issue in the es6 generated file in /es6/index.js and /lib/index.js on L9:

var _require = require('react/lib/ReactInputSelection');

@markbrouch
Copy link

markbrouch commented Nov 17, 2016

@radoi90 Looks like it just hasn't been published since the last change: https://www.npmjs.com/package/react-maskedinput

edit: it has been published since the last change, but it wasn't built first. @iamdustan will have to build and republish for this to be fixed.

@prabhath
Copy link

We are facing the same issue

@rfviolato
Copy link

rfviolato commented Nov 17, 2016

Yeah, the changes are not published :/

Well i guess i will copy the source to my project and use it as a custom component until they fix this issue.

@imchuck
Copy link

imchuck commented Nov 17, 2016

Any update on this? Where are you planning to republish to npm this fix?

@tonygentilcore
Copy link

Anything we can do to help get the fix released? Really excited to upgrade to 15.4.

@nguyenhose
Copy link

same problem here, it's awful when happened on deploy day.

@KittyGiraudel
Copy link

Yo! Thanks for the super quick fix. Any chance we could have a published build soon? :)

@hunterfortuin
Copy link

+1 on this! Would love to use the NPM package instead of copy/pasta code in my project.

@iamdustan
Copy link
Collaborator

Heyo. Apologies for the delay. I was on holiday with my family. Published [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests