Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Consider set_datanames to support negative selection. #1380

Open
3 tasks done
gogonzo opened this issue Oct 15, 2024 · 1 comment
Open
3 tasks done
Labels
core enhancement New feature or request

Comments

@gogonzo
Copy link
Contributor

gogonzo commented Oct 15, 2024

Feature description

Imagine following

data <- teal_data() |> within({
  iris <- iris
  mtcars <- mtcars
  dummy_1 <- 1
  dummy_2 <- 2
})
modules(
  example_module() |> set_datanames("mtcars"),
  example_module()
) |> set_datanames(-dummy_1, -dummy2)

Thanks to above, there will be an alternative solution to exclude datanames without using dot-prefix.

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.
@donyunardi
Copy link
Contributor

donyunardi commented Oct 17, 2024

Acceptance Criteria

  • Enhance set_datanames function to allow enable user to define negative selection when setting datanames
  • Analyze and Define clear condition on what happens to datanames when negative selection is applied to different scenarios (i.e. all, specific datasets selected, and transformer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants