Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teal framework Release #66

Open
donyunardi opened this issue Oct 15, 2024 · 7 comments
Open

teal framework Release #66

donyunardi opened this issue Oct 15, 2024 · 7 comments
Labels

Comments

@donyunardi
Copy link
Collaborator

donyunardi commented Oct 15, 2024

Summary

We have completed the following enhancements

Let's plan for a release of teal framework packages. We will handle teal modules packages release after this.

Release candidate:

  • [CRAN Release]: 0.3.0 teal.logger#94
    • teal.logger v0.3.0 (log_shiny_input_changes)
  • teal.reporter v0.4.0 (Archiver Module)
  • teal.code v0.6.0 (introduce names to qenv)
  • teal.widgets v0.5.1 (several bug fixes)
  • teal.data v0.7.0 (deprecate datanames)
  • teal.slice v0.6.0 (insertUI)
  • teal.transform v0.5.1 (minor code update)
  • teal v0.16.0 (teal_transform_module, insertUI)

Blockers

teal.data

teal/teal.slice

Deprecation activity

Deprecation activity

Make sure all CI pipelines are green before release (i.e. Scheduled pipeline, etc).

@m7pr
Copy link

m7pr commented Oct 15, 2024

I think we should do some manual testing on teal.gallery or/and tlg-catalog just in case.
Also review if all pipelines/workflows are green once we release (or before we release).

@m7pr
Copy link

m7pr commented Oct 16, 2024

@donyunardi should we revisit packages for soft deprecated functions and hard deprecate them? Also, for the hard deprecated functions, should we delete them? For example, should we delete all those teal.data functions that got hard deprecated 9 months ago ? https://github.com/insightsengineering/teal.data/blob/main/R/deprecated.R

@donyunardi
Copy link
Collaborator Author

Yeah, good idea. Let's review the deprecated functions in all packages.

For example, should we delete all those teal.data functions that got hard deprecated 9 months ago

I would say yes, 9 months ago is a reasonable time for us to remove this.

@m7pr
Copy link

m7pr commented Oct 17, 2024

@donyunardi @kumamiao what do you think about planning a community meeting with the summary of what got changed during the release? We could record and put that on YouTube and also include the link to the video in the release notes?

@donyunardi
Copy link
Collaborator Author

Sure, I'm open for it. 👍🏼

@donyunardi
Copy link
Collaborator Author

donyunardi commented Oct 17, 2024

I think we should do some manual testing on teal.gallery or/and tlg-catalog just in case.

I believe our shinytest2 implementation on teal frameworks and modules covers most of the key areas, but I'm open to doing minimal tests on teal.gallery. For tlg-catalog, I need a better understanding of what requires manual testing.

@m7pr, since you were involved in the shinytest2 implementation, could you help outline any gaps where manual testing is needed for both teal.gallery and tlg-catalog before the release?

Also review if all pipelines/workflows are green once we release (or before we release)

Yes, let's make sure this happens.

@kumamiao
Copy link

@donyunardi @kumamiao what do you think about planning a community meeting with the summary of what got changed during the release? We could record and put that on YouTube and also include the link to the video in the release notes?

Sure sounds good, was thinking the same as it's been a while since the last one. I'll be out Nov - Jan, so I was thinking sometime in Jan may be a good timing (assuming this will be aligning with the release timeline - right after the release?), but let's also see how the release work goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants