-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
teal framework Release #66
Comments
I think we should do some manual testing on |
@donyunardi should we revisit packages for soft deprecated functions and hard deprecate them? Also, for the hard deprecated functions, should we delete them? For example, should we delete all those teal.data functions that got hard deprecated 9 months ago ? https://github.com/insightsengineering/teal.data/blob/main/R/deprecated.R |
Yeah, good idea. Let's review the deprecated functions in all packages.
I would say yes, 9 months ago is a reasonable time for us to remove this. |
@donyunardi @kumamiao what do you think about planning a community meeting with the summary of what got changed during the release? We could record and put that on YouTube and also include the link to the video in the release notes? |
Sure, I'm open for it. 👍🏼 |
I believe our shinytest2 implementation on teal frameworks and modules covers most of the key areas, but I'm open to doing minimal tests on teal.gallery. For tlg-catalog, I need a better understanding of what requires manual testing. @m7pr, since you were involved in the shinytest2 implementation, could you help outline any gaps where manual testing is needed for both teal.gallery and tlg-catalog before the release?
Yes, let's make sure this happens. |
Sure sounds good, was thinking the same as it's been a while since the last one. I'll be out Nov - Jan, so I was thinking sometime in Jan may be a good timing (assuming this will be aligning with the release timeline - right after the release?), but let's also see how the release work goes. |
Summary
We have completed the following enhancements
Let's plan for a release of teal framework packages. We will handle teal modules packages release after this.
Release candidate:
names
to qenv)Blockers
teal.data
names
argument inget_code
to subset code for specific objects. teal.code#210qenv
object teal.code#211datanames
updates teal.data#338teal/teal.slice
check_modules_datanames()
is incorrect teal#1321data
raise warnings teal#1352teal_transform_module
to havedatanames = "all"
teal#1347set_datanames
to support negative selection. teal#1380modules/module
to contain more information teal#1378check_simple_name()
teal#1366teal_data_module
teal#1323modules
argument teal#1310teal
codebase usemagrittr
teal#1268lifecycle::badge
in teal packages #86crayon
tocli
teal#1417Deprecation activity
Deprecation activity
Make sure all CI pipelines are green before release (i.e. Scheduled pipeline, etc).
The text was updated successfully, but these errors were encountered: