-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensures required packages are in Imports section #774
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,3 @@ | ||
logger::log_appender(function(...) NULL, namespace = "teal.modules.general") | ||
if (requireNamespace("logger", quietly = TRUE)) { | ||
logger::log_appender(function(...) NULL, namespace = "teal.modules.general") | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,6 +44,7 @@ test_that("e2e - tm_data_table: Verify checkbox displayed over data table", { | |
}) | ||
|
||
test_that("e2e - tm_data_table: Verify module displays data table", { | ||
testthat::skip_if_not_installed("rvest") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have recently pushed changes into the Just thinking loud now, would it help if we would have the following instead?
My motivation is to avoid a lot of skip statements in the upstream packages like here. |
||
skip_if_too_deep(5) | ||
app_driver <- app_driver_tm_data_table() | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: this hashing function gets a logical vector as input