-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds decorators to tm_t_pp_basic_info
#1282
Adds decorators to tm_t_pp_basic_info
#1282
Conversation
…_decorate_output@main
…_decorate_output@main * 1187_decorate_output@main: [skip roxygen] [skip vbump] Roxygen Man Pages Auto Update docs: minor typo gg -> ggplot2 [skip roxygen] [skip vbump] Roxygen Man Pages Auto Update docs: documentation simplification [skip actions] Bump version to 0.9.1.9037 fixes error in adverse events when `ASTDY` is of difftime type (#1284)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you moved some options from the module to the template function. I think this is to make it easier to have a decorator on the interactive table of the shiny app and one for the static on the reporter.
My only concern with this approach is that the dt_decorator is quite complex (suppose because it cannot use make_teal_transform_server
) and I thought that we would only decorate objects that end up on the reporter. Perhaps we can talk about it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After checking with the team I was reminded that we are only adding decorators for objects that are on the reporters. Changes to the table_dt
(not used on the reporter) should be reverted.
…_decorate_output@main
Part of insightsengineering/teal#1371
Working example