Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verdepcheck #4

Merged
merged 14 commits into from
Sep 30, 2024
Merged

Fix verdepcheck #4

merged 14 commits into from
Sep 30, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Sep 23, 2024 •
edited
Loading

@pawelru pawelru marked this pull request as ready for review September 23, 2024 11:07
@pawelru
Copy link
Contributor Author

pawelru commented Sep 23, 2024

I have read the CLA Document and I hereby sign the CLA

@github-actions GitHub Actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------
R/parse_url.R                    9       0  100.00%
R/tag_examplesShinylive.R       72       0  100.00%
TOTAL                           81       0  100.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: ab7ed0f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

Unit Tests Summary

 1 files   2 suites   0s ⏱️
13 tests 13 ✅ 0 💤 0 ❌
50 runs  50 ✅ 0 💤 0 ❌

Results for commit ab7ed0f.

@github-actions GitHub Actions
Copy link
Contributor

Unit Tests Summary

 1 files   2 suites   0s ⏱️
13 tests 11 ✅ 2 💤 0 ❌
48 runs  46 ✅ 2 💤 0 ❌

Results for commit ab7ed0f.

donyunardi
donyunardi approved these changes Sep 26, 2024
View reviewed changes
Copy link

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment but everything else looks good so I'm approving this PR.

tests/testthat/test-tag_examplesShinylive.R Show resolved Hide resolved
@pawelru pawelru enabled auto-merge (squash) September 30, 2024 09:07
@pawelru pawelru merged commit d4b418b into main Sep 30, 2024
62 of 63 checks passed
@pawelru pawelru deleted the fix_verdepcheck branch September 30, 2024 09:07
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@donyunardi donyunardi donyunardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawelru @donyunardi