Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11 cran #13

Merged
merged 21 commits into from
Nov 27, 2024
Merged

11 cran #13

merged 21 commits into from
Nov 27, 2024

Conversation

shajoezhu
Copy link
Collaborator

No description provided.

Copy link
Contributor

github-actions bot commented Nov 18, 2024

Unit Tests Summary

 1 files  11 suites   11s ⏱️
25 tests 25 ✅ 0 💤 0 ❌
80 runs  80 ✅ 0 💤 0 ❌

Results for commit bb0de68.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 18, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
t_ae_pt_soc_diff_slide 💚 $3.25$ $-1.26$ $-2$ $+4$ $0$ $0$
t_dm_slide 💚 $1.84$ $-1.47$ $-4$ $+1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
t_ae_pt_soc_diff_slide 💚 $2.61$ $-1.25$ Test_table_creation_of_t_ae_pt_soc_diff_slide_safety_summary_table_prune_by_total_2
t_dm_slide 💚 $1.84$ $-1.47$ Test_demographic_table_creation_of_t_dm_slide

Results for commit 7dbd3a8

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 18, 2024

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------
R/assert.R                       26      25  3.85%    2, 7-43
R/autoslideR_error.R              7       0  100.00%
R/decorate.R                    138      96  30.43%   10, 49, 85-159, 186, 230-309
R/fastdocall.R                   28      28  0.00%    15-52
R/format_date.R                   9       9  0.00%    33-42
R/ft_formats.R                   54      54  0.00%    30-163
R/func_wrapper.R                 36      36  0.00%    9-50
R/generate_output.R              57      57  0.00%    41-137
R/helper_functions.R             36      20  44.44%   16-20, 63-80
R/log.R                          31      13  58.06%   26-39
R/null_report.R                   4       0  100.00%
R/package.R                       1       1  0.00%    72
R/save_output.R                  58      55  5.17%    34-43, 62-189
R/spec.R                         60      60  0.00%    30-155
R/t_ae_pt_diff_slide.R          122      17  86.07%   34-45, 151, 183-189, 202
R/t_ae_pt_slide.R                18       0  100.00%
R/t_ae_pt_soc_diff_slide.R       17       0  100.00%
R/t_ae_pt_soc_slide.R            17       0  100.00%
R/t_ae_slide.R                   74      74  0.00%    25-111
R/t_ae_summary_slide.R          154     154  0.00%    57-240
R/t_aesi_slide.R                132     132  0.00%    24-172
R/t_dd_slide.R                   23       0  100.00%
R/t_dm_slide.R                   32       0  100.00%
R/t_dor_slide.R                  65       0  100.00%
R/to_ft_funs.R                  221     221  0.00%    5-447
R/to_slides.R                   142     142  0.00%    51-319
R/util.R                        300     198  34.00%   19, 54, 69, 81-126, 185-278, 304-316, 322, 346, 354-449, 460-512, 529-535, 539, 568-571, 579-580
TOTAL                          1862    1392  25.24%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: bb0de68

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@shajoezhu
Copy link
Collaborator Author

Please add \value to .Rd files regarding exported methods and explain
the functions results in the documentation. Please write about the
structure of the output (class) and also what the output means. (If a
function does not return a value, please document that too, e.g.
\value{No return value, called for side effects} or similar) -> Missing
Rd-tags in up to 39 .Rd files:
autoslider_error.Rd: \value
autoslider_format.Rd: \value
build_table_header.Rd: \value
check_and_set_cutoff.Rd: \value
dec_paste.Rd: \value
decorate_outputs.Rd: \value
decorate-listing_df-method.Rd: \value
decorate-VTableTree-method.Rd: \value
decorate.autoslider_error.Rd: \value
decorate.default.Rd: \value
decorate.ggplot.Rd: \value
decorate.grob.Rd: \value
decorate.list.Rd: \value
decorate.Rd: \value
fastDoCall.Rd: \value
format_3d.Rd: \value
generate_output.Rd: \value
generate_outputs.Rd: \value
generate_slides.Rd: \value
lyt_to_side_by_side_two_data.Rd: \value
lyt_to_side_by_side.Rd: \value
mutate_actarm.Rd: \value
na_replace.Rd: \value
new_round.Rd: \value
null_report.Rd: \value
perc_perc.Rd: \value
ph_with_img.Rd: \value
preprocess_t_dd.Rd: \value
preprocess_t_ds.Rd: \value
print.decoratedGrob.Rd: \valu [... truncated]

\dontrun{} should only be used if the example really cannot be executed
(e.g. because of missing additional software, missing API keys, ...) by
the user. That's why wrapping examples in \dontrun{} adds the comment
("# Not run:") as a warning for the user. Does not seem necessary.
Please replace \dontrun with \donttest.

Please unwrap the examples if they are executable in < 5 sec, or replace
dontrun{} with \donttest{}.

-> filter_spec.Rd

You write information messages to the console that cannot be easily
suppressed.
It is more R like to generate objects that can be used to extract the
information a user is interested in, and then print() that object.
Instead of print() rather use message()/warning() or if(verbose)cat(..)
(or maybe stop()) if you really have to write text to the console.
(except for print, summary, interactive functions) -> R/to_ft_funs.R,
R/to_slides.R

  • update description
  • autoslider_error.Rd: \value
  • autoslider_format.Rd: \value
  • build_table_header.Rd: \value
  • check_and_set_cutoff.Rd: \value
  • dec_paste.Rd: \value
  • decorate_outputs.Rd: \value
  • decorate-listing_df-method.Rd: \value
  • decorate-VTableTree-method.Rd: \value
  • decorate.autoslider_error.Rd: \value
  • decorate.default.Rd: \value
  • decorate.ggplot.Rd: \value
  • decorate.grob.Rd: \value
  • decorate.list.Rd: \value
  • decorate.Rd: \value
  • fastDoCall.Rd: \value
  • format_3d.Rd: \value
  • generate_output.Rd: \value
  • generate_outputs.Rd: \value
  • generate_slides.Rd: \value
  • lyt_to_side_by_side_two_data.Rd: \value
  • lyt_to_side_by_side.Rd: \value
  • mutate_actarm.Rd: \value
  • na_replace.Rd: \value
  • new_round.Rd: \value
  • null_report.Rd: \value
  • perc_perc.Rd: \value
  • ph_with_img.Rd: \value
  • preprocess_t_dd.Rd: \value
  • preprocess_t_ds.Rd: \value
  • print.decoratedGrob.Rd: \valu [... truncated]
  • remove dontrun

@shajoezhu shajoezhu merged commit 51a7625 into main Nov 27, 2024
28 checks passed
@shajoezhu shajoezhu deleted the 11_cran branch November 27, 2024 15:37
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant