New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2 Initial Cropping of Viewfinder, needs more testing. #21

Open

fabiomercorillo wants to merge 1 commit into master from android-scan-frame-cropping

fabiomercorillo commented May 10, 2019

Hello, there is error in CameraSourcePreview.java at 59 row: the correct parameter of first args.optDouble method is 2, not 1

intent.putExtra("ViewFinderHeight", args.optDouble(2, .7));

Best regards


          #2 Initial Cropping of Viewfinder, needs more testing.

38c3aab

manojchandrashekar commented Oct 9, 2019

@fabiomercorillo Hello. Not a maintainer, but thanks for the PR. I was trying to crop the viewfinder as well.

One question - Does this also take care of the overlay (white rectangle) to fit to the expected cropping size?

I will try the code in the PR soon. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet