Fix base version check (absmach#1)

Signed-off-by: Dušan Borovčanin <[email protected]>
insighio · Mar 9, 2020 · 42d126c · 42d126c
1 parent 7cb7855
commit 42d126c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/senml.go b/senml.go
@@ -192,6 +192,9 @@ func Validate(p Pack) error {
 		if bver == 0 && r.BaseVersion != 0 {
 			bver = r.BaseVersion
 		}
+		if bver != 0 && r.BaseVersion == 0 {
+			r.BaseVersion = bver
+		}
 		if r.BaseVersion != bver {
 			return ErrVersionChange
 		}

diff --git a/senml_test.go b/senml_test.go
@@ -197,6 +197,9 @@ func TestValidate(t *testing.T) {
 	noValue.Records[0].BaseSum = 0
 	noValue.Records[0].Sum = nil
 
+	validVersion := pack()
+	validVersion.Records[1].BaseVersion = 0
+
 	multiVersion := pack()
 	multiVersion.Records[1].BaseVersion = 3
 
@@ -235,6 +238,11 @@ func TestValidate(t *testing.T) {
 			p:    noValue,
 			err:  senml.ErrNoValues,
 		},
+		{
+			desc: "validate version",
+			p:    validVersion,
+			err:  nil,
+		},
 		{
 			desc: "validate multiple versions",
 			p:    multiVersion,