Pass variables to result function #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 18, 2021 10:29
Allows mocked data to be generated based on the variables passed into the query.
|
This is cool. |
|
BTW your commit messages are in a mixture of imperative mood and declarative mood :D Most organisations seem to be mandating imperative right now, using that for this repo. |
|
@insidewhy Thanks for this package, it makes working with apollo mocks much easier. Any idea when we might see a release or beta with this PR included? |
|
@ajdean @eli0shin Released 2.0.1. I think the built-in mock link should be replaced with wildcard-mock-link so I opened this feature request apollo: apollographql/apollo-feature-requests#298 Would appreciate your reactions or comments on that issue. Thanks again for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought it would be handy when using a result function to be able to pass the query variables into the function, so they could be used to help generate the mock data.
Had a go at updating the code to make it so and it seems to work OK. Have also added a test around the functionality.