-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prep_nisar
: update for changes in NISAR GUNW products
#1158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mirzaees. Please check the two minor comments below. @scottstanie could you take a look at the rest of the change?
@@ -61,9 +61,9 @@ def load_nisar(inps): | |||
print(f"Found {len(input_files)} unwrapped files") | |||
|
|||
if inps.subset_lat: | |||
bbox = (inps.subset_lat[0], inps.subset_lon[0], inps.subset_lat[1], inps.subset_lon[1]) | |||
bbox = (inps.subset_lon[0], inps.subset_lat[0], inps.subset_lon[1], inps.subset_lat[1]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this isn't converting from SNWE to (left, bottom, right top), it's just fixing the ordering for (left, bottom, right, top)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes the input arguments follows mintpy subsetting with two arguments --sub-lat
and --sub-lon
. They are ordered to make bbox here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mirzaees . Please see my comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hfattahi @scottstanie and @yunjunz
I changed as you suggested, let's wait for some good data to test before merging
prep_nisar
: update for changes in NISAR GUNW products
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it will be great to test with updated GUNW before merging this PR. @jplzhan and @katia-tymofyeyeva are working on updating the GUNW test data.
Description of proposed changes