Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prep_nisar: update for changes in NISAR GUNW products #1158

Merged
merged 11 commits into from
Mar 25, 2024

Conversation

mirzaees
Copy link
Collaborator

Description of proposed changes

  • The mask file is updated in GUNW products which is corrected
  • There was a bug related to projection that subset was not reading bounding box in the correct order.
  • A fix is introduced to correctly add projection to the metadata

@mirzaees mirzaees requested a review from yunjunz March 11, 2024 17:44
@yunjunz yunjunz requested a review from scottstanie March 12, 2024 02:04
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mirzaees. Please check the two minor comments below. @scottstanie could you take a look at the rest of the change?

src/mintpy/tropo_pyaps3.py Show resolved Hide resolved
src/mintpy/prep_nisar.py Outdated Show resolved Hide resolved
@@ -61,9 +61,9 @@ def load_nisar(inps):
print(f"Found {len(input_files)} unwrapped files")

if inps.subset_lat:
bbox = (inps.subset_lat[0], inps.subset_lon[0], inps.subset_lat[1], inps.subset_lon[1])
bbox = (inps.subset_lon[0], inps.subset_lat[0], inps.subset_lon[1], inps.subset_lat[1])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this isn't converting from SNWE to (left, bottom, right top), it's just fixing the ordering for (left, bottom, right, top)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the input arguments follows mintpy subsetting with two arguments --sub-lat and --sub-lon . They are ordered to make bbox here

Copy link
Collaborator

@hfattahi hfattahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mirzaees . Please see my comments below.

src/mintpy/prep_nisar.py Outdated Show resolved Hide resolved
src/mintpy/prep_nisar.py Outdated Show resolved Hide resolved
src/mintpy/prep_nisar.py Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@mirzaees mirzaees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hfattahi @scottstanie and @yunjunz
I changed as you suggested, let's wait for some good data to test before merging

@yunjunz yunjunz changed the title Update for changes in NISAR GUNW products prep_nisar: update for changes in NISAR GUNW products Mar 14, 2024
@yunjunz yunjunz changed the title prep_nisar: update for changes in NISAR GUNW products prep_nisar: update for changes in NISAR GUNW products Mar 14, 2024
Copy link
Collaborator

@hfattahi hfattahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it will be great to test with updated GUNW before merging this PR. @jplzhan and @katia-tymofyeyeva are working on updating the GUNW test data.

@mirzaees mirzaees merged commit ccc946c into insarlab:main Mar 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants